Add sslmode=allow support and fix =prefer retry #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
force-pushed
the
t716-sslmode-allow
branch
from
77d4742
to
c993737
Compare
fantix
force-pushed
the
t716-sslmode-allow
branch
7 times, most recently
from
7ee46eb
to
f38aa70
Compare
elprans
reviewed
Mar 24, 2021
We didn't really retry the connection without SSL if the first SSL connection fails under sslmode=prefer, that led to an issue when the server has SSL support but explicitly denies SSL connection through pg_hba.conf. This commit adds a retry in a new connection, which makes it easy to implement the sslmode=allow retry. Fixes MagicStack#716
fantix
force-pushed
the
t716-sslmode-allow
branch
from
f38aa70
to
25323fd
Compare
elprans
approved these changes
Mar 24, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't really retry the connection without SSL if the first SSL connection fails under
sslmode=prefer, that led to an issue when the server has SSL support but explicitly denies SSL connection throughpg_hba.conf. This commit adds a retry in a new connection, which makes it easy to implement thesslmode=allowretry.Fixes #716