Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing PyPI wheels #993

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix missing PyPI wheels #993

merged 2 commits into from
Feb 13, 2023

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Jan 20, 2023 •
edited
Loading

fix for #954 xref pypa/cibuildwheel#1261 (reply in thread)
e.g. cp36-manylinux_x86_64 was missing on pypi, because the first line was swallowed when using inputs:

$ cibuildwheel --print-build-identifiers --platform linux --arch x86_64,aarch64 | grep cp |  jq -nRc '{"only": inputs, "os": "ubuntu-latest"}'
{"only":"cp36-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp37-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp38-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp39-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp310-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp311-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp36-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp37-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp38-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp39-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp310-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp311-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp36-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp37-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp38-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp39-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp310-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp311-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp36-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp37-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp38-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp39-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp310-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp311-musllinux_aarch64","os":"ubuntu-latest"}
$ cibuildwheel --print-build-identifiers --platform linux --arch x86_64,aarch64 | grep cp |  jq -Rc '{"only": inputs, "os": "ubuntu-latest"}'
{"only":"cp37-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp38-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp39-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp310-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp311-manylinux_x86_64","os":"ubuntu-latest"}
{"only":"cp36-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp37-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp38-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp39-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp310-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp311-manylinux_aarch64","os":"ubuntu-latest"}
{"only":"cp36-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp37-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp38-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp39-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp310-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp311-musllinux_x86_64","os":"ubuntu-latest"}
{"only":"cp36-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp37-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp38-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp39-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp310-musllinux_aarch64","os":"ubuntu-latest"}
{"only":"cp311-musllinux_aarch64","os":"ubuntu-latest"}

@ddelange
Fix for jq skipping first line
46b6b26 
`input`
Outputs one new input.

`inputs`
Outputs all remaining inputs, one by one.
@ddelange
Clean up fix
6ae2143 
pypa/cibuildwheel#1261 (reply in thread)
@ddelange
Copy link
Contributor Author

cc @elprans

@ddelange ddelange changed the title Fix for jq skipping first line Fix missing PyPI wheels Jan 25, 2023
@ddelange
Copy link
Contributor Author

@elprans friendly ping :)

@elprans elprans merged commit 247b1a5 into MagicStack:master Feb 13, 2023
lezram pushed a commit to lezram/asyncpg that referenced this pull request Apr 17, 2023
@ddelange @lezram
Fix missing PyPI wheels (MagicStack#993)
6155213 
Fix for jq skipping first line

`input`
Outputs one new input.

`inputs`
Outputs all remaining inputs, one by one.

pypa/cibuildwheel#1261 (reply in thread)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans elprans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelange @elprans