Fix #195, Don't log ssl.CertificateError #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 1, 2018
uvloop/includes/stdlib.pxi
Outdated
| @@ -126,6 +126,13 @@ cdef int ssl_SSL_ERROR_WANT_READ = ssl.SSL_ERROR_WANT_READ | |||
| cdef int ssl_SSL_ERROR_WANT_WRITE = ssl.SSL_ERROR_WANT_WRITE | |||
| cdef int ssl_SSL_ERROR_SYSCALL = ssl.SSL_ERROR_SYSCALL | |||
|
|
|||
| cdef FATAL_ERROR_IGNORE = ( | |||
There was a problem hiding this comment.
Can we rename this to FATAL_SSL_ERROR_IGNORE
There was a problem hiding this comment.
Makes sense! Will do, thx.
|
What's the status on this? |
fantix
force-pushed
the
t195_dont_log_ssl_cert_err
branch
from
4477e31 to
ad0b9c4
Compare
|
There it is! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #195, refs python/cpython#9169