Improve UDPTransport.sendto address validation (fixes: #214) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Jan 8, 2019
uvloop/handles/udp.pyx
Outdated
| @@ -188,3 +182,17 @@ cdef class UDPTransport(UVBaseTransport): | |||
| # Ensure that what we buffer is immutable. | |||
| self.buffer.append((bytes(data), addr)) | |||
| self._maybe_pause_protocol() | |||
|
|
|||
| @functools.lru_cache() | |||
| def _validate_address(self, object addr): | |||
There was a problem hiding this comment.
Can you try to make it a standalone function (not a method)? That way the cache will be shared across different transports.
When UDPTransport.sendto is called with a destination address, only perform the validation once and store the result in an LRU cache. Also store some of the socket's properties (family, proto, type) as integers to avoid repeatedly fetching these properties and converting them to integers.
jlaine
force-pushed
the
udp-transport-sendto
branch
from
0016813 to
ac85414
Compare
|
Thank you! |
|
Thanks for the amazingly fast turnaround! |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UDPTransport.sendto is called with a destination address, only
perform the validation once and store the result in an LRU cache. Also
store some of the socket's properties (family, proto, type) as integers
to avoid repeatedly fetching these properties and converting them to integers.