Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose uv_loop_t pointer for integration with other C-extensions #310

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Expose uv_loop_t pointer for integration with other C-extensions #310

merged 3 commits into from
Aug 13, 2022

Conversation

pranavtbhat
Copy link
Contributor

This PR adds a couple of functions to expose the raw uvloop pointer as int/pycapsule. #307

I can remove the int one if we feel it's not required.

@pranavtbhat pranavtbhat requested a review from 1st1 January 17, 2020 03:30
@ghost
Copy link

ghost commented Jan 17, 2020

uint64_t is not guaranteed to be the size of void *, why not use the dedicated feature and get it right with one single function?

@pranavtbhat
Copy link
Contributor Author

@1st1 Your thoughts on pycapsule vs int?

@pranavtbhat
Copy link
Contributor Author

The build failure looks unrelated.

@XeCycle
Copy link

XeCycle commented Jun 7, 2021

My +1 on this feature; regarding uint64_t, uintptr_t may be better. FWIW there are existing libraries exposing pointers as integers (e.g. numpy.ndarray.ctypes.data); integers are easier to work with when using cffi.

@jensbjorgensen
Copy link
Contributor

Hello, I'm interested in this feature and actually was checking outstanding pull requests before submitting my own. Looking over the above the failed check seems unrelated but as reviewer noted the integer should be uintptr_t not uint64_t. I'm not sure how/if it's possible for me to patch the submitted pull request. Should I submit my own?

@fantix
Copy link
Member

fantix commented Aug 13, 2022

Thanks for the PR and sorry for the delay! I think having an int pointer in Python doesn't make much sense - it'll be used in a C context anyways, so I think it's fine to only go with the standard API. (I was suggesting the Cython API in another PR, but I like the capsule better - just importing is sufficient, no linking needed!)

I pushed a fix with a Cython test that actually checks the encapsulated pointers.

@fantix fantix mentioned this pull request Aug 13, 2022
Merged
@fantix fantix merged commit b332eb8 into MagicStack:master Aug 13, 2022
@ben9923 ben9923 mentioned this pull request Aug 23, 2022
Merged
@pwuertz
Copy link

pwuertz commented Aug 28, 2022

Two questions on this

  • Is there a new uvloop release on the horizon that includes this feature? ;)

  • Any words of caution concerning libuv API compatibility? Is uvloop using a statically linked libuv library or a shared library that we'd re-use in a c-extension? Does uvloop use a vanilla libuv for which we can expect SemVer ABI stability?

@fantix
Copy link
Member

fantix commented Aug 28, 2022

  • Is there a new uvloop release on the horizon that includes this feature? ;)

Yes, we'll try to release a new version in the next week or two.

  • Any words of caution concerning libuv API compatibility?

Hmm we should probably re-export some of the libuv version-checking utils if we're statically linking, @1st1 wdyt?

Is uvloop using a statically linked libuv library or a shared library that we'd re-use in a c-extension?

This depends, by default it is statically linked but this can be override with the --use-system-libuv option.

Does uvloop use a vanilla libuv for which we can expect SemVer ABI stability?

Yes, https://github.com/MagicStack/uvloop/tree/master/vendor

@fantix fantix mentioned this pull request Sep 9, 2022
Merged
@fantix
Copy link
Member

fantix commented Sep 9, 2022

  • Any words of caution concerning libuv API compatibility?

Hmm we should probably re-export some of the libuv version-checking utils if we're statically linking, @1st1 wdyt?

uv_version() is now exposed in #491.

This was referenced Sep 9, 2022
Closed
Closed
fantix added a commit that referenced this pull request Sep 13, 2022
@fantix
uvloop v0.17.0
c4c3f9f 
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.

Changes
=======

* Expose uv_loop_t pointer for integration with other C-extensions (#310)
  (by @pranavtbhat in b332eb8 for #310)

* Support python 3.11+ (#473)
  (by @zeroday0619 in 8e42921 for #473)

* Expose libuv uv_fs_event functionality (#474)
  (by @jensbjorgensen @fantix in 74d381e for #474)

* Activate debug mode when `-X dev` is used
  (by @jack1142 in 637a77a)

* Expose uv_version() for libuv API compatibility (#491)
  (by @fantix in 089f6cb for #491)

* Fix loop.getaddrinfo() and tests (#495)
  (by @fantix in 598b16f for #495)

* Bump to libuv 1.43.0
  (by @fantix in 94e5e53)

Fixes
=====

* _TransProtPair is no longer defined in asyncio.events
  (by @jensbjorgensen in fae5f7f)

* use a TypeVar for asyncio.BaseProtocol (#478)
  (by @graingert in 3aacb35 for #478)

* Fix segfault in TimerHandle.when() after cleared
  (by @jensbjorgensen in c39afff for #469)

* Avoid self._errpipe_write double close (#466)
  (by @graingert in 72140d7 for #466)

* Fix typo in test (#456)
  (by @kianmeng in 033d52d for #456)

* Fix potential infinite loop (#446)
  (by @kfur in ada43c0 for #446)

* use a stack of self._fds_to_close to prevent double closes (#481)
  (by @graingert in 3214cf6 for #481)

* Fix incorrect main thread id value forking from a thread  (#453)
  (by @horpto @fantix in e7934c8 for #453)

* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
  (by @byllyfish in e04637e for #439)

* Queue write only after processing all buffers (#445)
  (by @jakirkham @fantix in 9c6ecb6 for #445)

* Drop Python 3.6 support for thread ident
  (by @fantix in 9c37930)

* bugfix: write to another transport in resume_writing() fails (#498)
  (by @fantix in d2deffe for #498)

Build
=====

* Upgrade GitHub Actions (#477) (#480)
  (by @cclauss in fcbf422 for #477, 1008694 for #480)

* typo `same as same`
  (by @YoSTEALTH in fedba80)

* setup.py: allow to override extra_compile_args (#443)
  (by @giuliobenetti in a130375 for #443)

* Drop hack in setup.py in finalize_options (492)
  (by @fantix in 2f1bc83 for #492)

* Fix tests invocation on release CI worklow (#489)
  (by @ben9923 in d6a2b59 for #489)

Documentation
=============

* use asyncio.Runner loop_factory on 3.11+ (#472)
  (by @graingert in 31ba48c for #472)

* Fix CI badge in docs, remove remaining Travis CI references from docs
  (by @Nothing4You in c6901a7)

* Fix typo in README
  (by @monosans in 73d7253)
@fantix fantix mentioned this pull request Sep 13, 2022
Merged
fantix added a commit that referenced this pull request Sep 14, 2022
@fantix
uvloop v0.17.0
afb3268 
This release adds Python 3.11 support, updates bundled libuv to 1.43.0
and fixes a handful of issues.

Changes
=======

* Expose uv_loop_t pointer for integration with other C-extensions (#310)
  (by @pranavtbhat in b332eb8 for #310)

* Support python 3.11+ (#473)
  (by @zeroday0619 in 8e42921 for #473)

* Expose libuv uv_fs_event functionality (#474)
  (by @jensbjorgensen @fantix in 74d381e for #474)

* Activate debug mode when `-X dev` is used
  (by @jack1142 in 637a77a)

* Expose uv_version() for libuv API compatibility (#491)
  (by @fantix in 089f6cb for #491)

* Fix loop.getaddrinfo() and tests (#495)
  (by @fantix in 598b16f for #495)

* Bump to libuv 1.43.0
  (by @fantix in 94e5e53)

Fixes
=====

* _TransProtPair is no longer defined in asyncio.events
  (by @jensbjorgensen in fae5f7f)

* use a TypeVar for asyncio.BaseProtocol (#478)
  (by @graingert in 3aacb35 for #478)

* Fix segfault in TimerHandle.when() after cleared
  (by @jensbjorgensen in c39afff for #469)

* Avoid self._errpipe_write double close (#466)
  (by @graingert in 72140d7 for #466)

* Fix typo in test (#456)
  (by @kianmeng in 033d52d for #456)

* Fix potential infinite loop (#446)
  (by @kfur in ada43c0 for #446)

* use a stack of self._fds_to_close to prevent double closes (#481)
  (by @graingert in 3214cf6 for #481)

* Fix incorrect main thread id value forking from a thread  (#453)
  (by @horpto @fantix in e7934c8 for #453)

* create_subprocess_exec should treat env={} as empty environment (#439) (#454)
  (by @byllyfish in e04637e for #439)

* Queue write only after processing all buffers (#445)
  (by @jakirkham @fantix in 9c6ecb6 for #445)

* Drop Python 3.6 support for thread ident
  (by @fantix in 9c37930)

* bugfix: write to another transport in resume_writing() fails (#498)
  (by @fantix in d2deffe for #498)

Build
=====

* Upgrade GitHub Actions (#477) (#480)
  (by @cclauss in fcbf422 for #477, 1008694 for #480)

* typo `same as same`
  (by @YoSTEALTH in fedba80)

* setup.py: allow to override extra_compile_args (#443)
  (by @giuliobenetti in a130375 for #443)

* Drop hack in setup.py in finalize_options (492)
  (by @fantix in 2f1bc83 for #492)

* Fix tests invocation on release CI worklow (#489)
  (by @ben9923 in d6a2b59 for #489)

Documentation
=============

* use asyncio.Runner loop_factory on 3.11+ (#472)
  (by @graingert in 31ba48c for #472)

* Fix CI badge in docs, remove remaining Travis CI references from docs
  (by @Nothing4You in c6901a7)

* Fix typo in README
  (by @monosans in 73d7253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pranavtbhat @XeCycle @jensbjorgensen @fantix @pwuertz