Use hard-coded FD for stdio in subprocess #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FD=0/1/2 for
subprocess(stdin=None, stdout=None, stderr=None)
. This aligns uvloop with the same behavior in asyncio - when stdin, stdout or stderr is None, the subprocess will use FD 0, 1 or 2 now instead ofsys.stdin
,sys.stdout
orsys.stderr
.asyncio eventually calls this to create subprocess, where
p2cread
,c2pwrite
orerrwrite
are-1
and the current FD 0, 1 and 2 are left untouched to eventually callexecv()
.Fixes #136