restore uvloop.new_event_loop and other missing uvloop members to typing #573
Conversation
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
from
e08494f
to
83fbb49
Compare
There was a problem hiding this comment.
adding this file removed the useful members like 'new_event_loop' which is needed for asyncio.Runner(...)
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
2 times, most recently
from
0370a92
to
ec9c6ce
Compare
graingert
changed the title
graingert
force-pushed
the
uvloop-missing-nel-install-elp-etc
branch
from
d887fa4
to
7ea847c
Compare
|
@fantix can I get a review on this please? It's blocking mypy in unicorn |
| loop.set_debug(debug) | ||
| return loop.run_until_complete(wrapper()) | ||
| finally: | ||
| if _typing.TYPE_CHECKING: |
There was a problem hiding this comment.
Can we just inline the typing and omit this TYPE_CHECKING check?
There was a problem hiding this comment.
I tried that, if you see the history of the PR, but it took too many changes
There was a problem hiding this comment.
I see now. What about adding new_event_loop to __init__.pyi?
There was a problem hiding this comment.
I tried that first also and it means the other members aren't type checked
| loop.set_debug(debug) | ||
| return loop.run_until_complete(wrapper()) | ||
| finally: | ||
| if _typing.TYPE_CHECKING: |
There was a problem hiding this comment.
I see now. What about adding new_event_loop to __init__.pyi?
Changes ======= * Drop support of Python 3.7 and update CI (#578) (by @fantix in ee5ad26 for #578) Fixes ===== * Restore uvloop.new_event_loop and other missing uvloop members to typing (#573) (by @graingert in 5c500ee for #573) * Fix docstring of loop.shutdown_default_executor (#535) (by @Gelbpunkt in 919da56 for #535) * Fix CI status badge (#522) (by @shuuji3 in 0e9ff6c for #522)
No description provided.