Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic flyouts are not shown when animated #3807

Closed
didster opened this issue May 22, 2020 · 2 comments
Closed

Dynamic flyouts are not shown when animated #3807

didster opened this issue May 22, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@didster
Copy link

didster commented May 22, 2020

Describe the bug
Dynamic flyouts (those added to FlyoutsControl.Items at runtime) dont show with animations enabled (the default). Worked fine prior to around 2.0.0-alpha0872 and I assume related to this commit.

Demo app exhibits same behaviour - all flyouts (which are inlined in xaml) work fine other than dynamic button which doesn't show.

To Reproduce
As per demo code

var flyout = new DynamicFlyout
                      {
                             Header = "Dynamic flyout"
                         };
            // when the flyout is closed, remove it from the hosting FlyoutsControl
            RoutedEventHandler closingFinishedHandler = null;
            closingFinishedHandler = (o, args) =>
                {
                    flyout.ClosingFinished -= closingFinishedHandler;
                    flyoutsControl.Items.Remove(flyout);
                };
            flyout.ClosingFinished += closingFinishedHandler;

            flyoutsControl.Items.Add(flyout);

            flyout.IsOpen = true;

Addition of flyout.AreAnimationsEnabled = false; results in the flyout showing as expected.

Expected behavior
The flyout is shown animated

Environment(please complete the following information):

  • MahApps.Metro version [2.0.0-alpha0879]
  • OS: Win10 18362
  • Visual Studio 2019 (16.5.2)
  • .NET Framework: Core 3.1
@punker76 punker76 self-assigned this May 22, 2020
@punker76 punker76 added the Bug label May 22, 2020
@punker76 punker76 added this to the 2.0.0 milestone May 22, 2020
@punker76
Copy link
Member

@didster Thx for using the latest alpha hot stuff and reporting this issue. It's now fixed and will be available with the final v2.0 release.

@didster
Copy link
Author

didster commented May 23, 2020

@punker76 Pleasure, just raised another ;-). Thanks for the vast efforts for v2 its coming on great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants