Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker may loose SelectedColor if DropDown closes #3991

Closed
timunie opened this issue Dec 4, 2020 · 0 comments · Fixed by #3992
Closed

ColorPicker may loose SelectedColor if DropDown closes #3991

timunie opened this issue Dec 4, 2020 · 0 comments · Fixed by #3992
Labels
Bug
Milestone
2.4.2

Comments

@timunie
Copy link
Collaborator

timunie commented Dec 4, 2020

Describe the bug

If you select a Color from the RecentColorPalette and close the ColorPicker the control loses the SelectedColor and sets the default instead.

Steps to reproduce

  1. Set AddToRecentColor=ColorPickerClosed
  2. Select different colors
  3. Select a color from recent colors.
  4. Open and close the ColorPicker serveral times

Expected behavior

ColorPicker should remember the selection.

Actual behavior

ColorPicker looeses the selection. This behaviour exists since the last recent changes. The problem seems to be related to removing these lines:
image

Environment

MahApps.Metro version: v2.4.1
Windows build number: Win10 20H2 [Version 10.0.19042.662]
Visual Studio: 2019 16.6.0
Target Framework: .Net Core 3.1 (v4.5.2, v4.7.2)

Screenshots

ColorPickerIssue
@timunie timunie added the Bug label Dec 4, 2020
@timunie timunie mentioned this issue Dec 4, 2020
Merged
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Dec 4, 2020
@punker76
(MahAppsGH-3991) Fix adding colors to recent colors by AddColorToRece…
e5cde11 
…ntColors
@punker76 punker76 added this to the 2.4.2 milestone Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Milestone
2.4.2
Development

Successfully merging a pull request may close this issue.

Fix RecentColor - Issue timunie/MahApps.Metro
2 participants
@punker76 @timunie