Fix for overflow exception (multi monitor) #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if x and y are both -1, the packed integer is 0xFFFFFFFF which is not a valid Int32, thus an overflow exception is thrown in IntPtr.ToInt32().
|
@NickWard if you're still around, could you verify if this fixes your issue? |
|
@NickWard It will be hard to get the exception again, since it should only happen when both X and Y are -1. |
Closed
AzureKitsune
added a commit
that referenced
this pull request
Feb 12, 2014
Fix for overflow exception (multi monitor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
XandYare both-1, the packed integer is0xFFFFFFFFwhich is not a validInt32, thus aSystem.OverflowExceptionis thrown inIntPtr.ToInt32().To fix this,
IntPtr.ToInt64()is used instead.Fixes #624