updated TextboxHelper.Watermark to respect Textbox Padding #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My temporary fix is to hide the TextBox border, and wrap a <Border Grid.Row="1" BorderThickness="1" Margin="5" BorderBrush="{StaticResource TextBoxBorderBrush}" Padding="10">
<TextBox Name="txtSearch" BorderThickness="0" controls:TextboxHelper.Watermark="Enter search keyword such as 'php' or 'bower'" KeyUp="txtSearch_KeyUp"></TextBox>
</Border> |
punker76
added a commit
that referenced
this pull request
May 30, 2014
updated TextboxHelper.Watermark to respect Textbox Padding
punker76
added a commit
that referenced
this pull request
Jun 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried adding padding to a TextBox while using TextboxHelper.Watermark, the watermark does not respect the padding value, making it awkward and out of place.
I've updated the styles for the watermark TextBlock to respect the TextBox's padding value. Hope that works!