-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underlined TabControl #1425
Underlined TabControl #1425
Conversation
That's pretty. 👍 |
The only problem now is to figure out where we put the property for the activation of this feature |
👍 |
I think the AccentColorBrush works fine, it is really cohesive. It should match the rest of the TabControl (and window) |
@flagbug when you say "where to put the property", do you mean on the TabControl vs. the TabItem? |
@flagbug why not a separate style? |
@punker76 wouldn't a new style have to be created for each "type" of TabControl (i.e. TabControl, MetroAnimatedSingleRowTabControl, MetroAnimatedTabControl)? I see this getting confusing for users very quickly... Wouldn't it be easier to have a boolean property called |
@amkuchta We don't own the |
What about an attached property? Something like |
@flagbug any updates on this? Don't mean to add any pressure, but I am really interested in this feature for my project (it's gorgeous lol) |
Same here. We did our own style for now, but we are looking forward from this. |
poke? 👉 |
I much prefer the look of this implementation to the current TabControl options. Hopefully this can be merged in soon. |
There you go |
For anyone else planning on using this, in order to get the underline to extend across to the edge of your window, you will need to insert a disabled tab with an empty header that is stretched to fill the remaining space in your TabControl |
Also, @flagbug , this is gorgeous, thank you very much! |
@amkuchta How exactly, have been trying different ways and didn't manage to achieve that. |
Hey guys, |
<TabControl mahapps:TabControlHelper.Underlined="SelectedTabItem"/>
UnderlineBrush
UnderlineSelectedBrush
UnderlineMouseOverBrush
UnderlineMouseOverSelectedBrush Sorry for Question |
Fixes #960