LoginDialog Password Preview Feature #1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a password binding class for the passwordbox in order to setup the windows 8 "preview password" button on the passwordbox control.
Add EnablePasswordPreview for LoginDialog. If enabled, the "Win8MetroPasswordBox" style is applied to the password box which will enable the password preview button.
A converter for showing and hiding a control based upon text. Used for the Password Preview added to the LoginDialog.
Add new style for previewing on passwordbox control inside the LoginDialog.
Setup password binding for the preview text.
Add Menu for Show LoginDialog w/ Password Preview
Add Menu Item Click event for showing a LoginDialog with the password preview enabled.
New style for password previewing on passwordbox
Password Binding for Win8 Password Preview
Add EnablePasswordPreview for LoginDialog
Add converter for show/hide if there is text
Setup password binding for the preview text
Add Menu for Show LoginDialog w/ Password Preview
Add menu click event - LoginDialog w/ Pass Prev
|
FYI: New style for password previewing on passwordbox … (x) d6fefd7 Merge pull request #4 from djengineerllc/patch-3 … d070f7d Merge pull request #1 from djengineerllc/patch-7 … (x) b967821 |
|
I'm a bit lost here, can you squash all those commits so we can get rid of all those merge commits? |
|
Is there a chance you complete this pull request? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to use the Password Preview feature like in Windows 8 login to the LoginDialog. It's optional and doesn't have to be used. I used the eye icon in the MahApps icon library for the password preview button.
I merged templates and styles from MahApps & from WPFSmartLibrary. I integrated in what was needed from the WPFSmartLibrary into the MahApps w/o adding a DLL reference to WPFSmartLibrary (https://wpfsmartlibrary.codeplex.com/).