Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ButtonsPlacement property to have possibility to set NUD on the left side #2024

Merged
merged 7 commits into from
Jul 8, 2015

Conversation

QuantumDeveloper
Copy link
Contributor

No description provided.

public static readonly DependencyProperty MinimumProperty = DependencyProperty.Register(
public static readonly DependencyProperty ButtonsPlacementProperty = DependencyProperty.Register(
"ButtonsPlacement",
typeof(Dock),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an enumeration for this, instead using Dock?

something like

enum ButtonsPlacementType
{
    Left,
    Right
}

i think all other values make no sense

@punker76
Copy link
Member

punker76 commented Jul 7, 2015

@QuantumDeveloper two notes...

  1. why changing the buttons from "+ -" to "- +"
  2. the ClearTextButton is still right...
    image

@QuantumDeveloper
Copy link
Contributor Author

  1. I made mirroring of the buttons to make it symmetric. If you want, I can change order.
  2. Need to deal with it.

@punker76 punker76 added this to the 1.2.0 milestone Jul 8, 2015
punker76 added a commit that referenced this pull request Jul 8, 2015
Implement ButtonsPlacement property to have possibility to set NUD on the left side
@punker76 punker76 merged commit a879732 into MahApps:master Jul 8, 2015
@thoemmi
Copy link
Collaborator

thoemmi commented Jul 8, 2015

Wouldn't be ButtonsPlacement a better name than ButtonsPlacementVariant? /cc @punker76

@punker76
Copy link
Member

punker76 commented Jul 8, 2015

@thoemmi what about Location for the enumeration and ButtonLocation for the dp? (about how xceed does it)

@thoemmi
Copy link
Collaborator

thoemmi commented Jul 8, 2015

Maybe ButtonsAlignment is more consistent with WPF's naming. And ...Buttons should be plural, because it refers to all buttons of a TextBox.

@punker76
Copy link
Member

punker76 commented Jul 8, 2015

@thoemmi yeah, i forgot the s and i am agreed with ButtonsAlignment... for both? enum and dp?

@thoemmi
Copy link
Collaborator

thoemmi commented Jul 8, 2015

Yes, I'd call both the enum and the dp ButtonsAlignment.

@punker76
Copy link
Member

punker76 commented Jul 8, 2015

@thoemmi done 66e2665

@thoemmi
Copy link
Collaborator

thoemmi commented Jul 8, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants