Only apply SizeToContent workaround when necessary #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punker76
added a commit
that referenced
this pull request
Sep 14, 2015
Only apply SizeToContent workaround when necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
SizeToContentworkaround is only necessary whenResizeMode != NoResize. The workaround solves the problem of black bars appearing at the right and bottom edges of the window. But whenResizeMode == NoResize, no such black bars appear.The reason for this pull request is that the
SizeToContentworkaround turns out to be a problem in someSizeToContent=WidthAndHeightedge cases. Specifically, when the size of the content changes as the window is loading, due to code inSourceInitializedandLayoutUpdatedin our app. Unfortunately the repro is pretty complicated, and I haven't been able to create a minimal repro.