Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cleartext button in the passwordbox doesn't match the one in a textbox #310

Merged
3 commits merged into from
Jan 22, 2013
Merged

The cleartext button in the passwordbox doesn't match the one in a textbox #310

3 commits merged into from
Jan 22, 2013

Conversation

henrik-oscarsson
Copy link

There were some triggers missing. See the screenshot below that illustrates how the cleartext button looks when hovering the mouse over it (on a textbox):

textbox-mouseover
Also, it changes color when pressed (as expected).

Here's a screenshot of the password box, when hovering the button:

passbox-mouseover

You can see that the 'X' becomes black, but the background isn't affected. This PR fixes that issue.

@henrik-oscarsson
Copy link
Author

Fixed the foreground of the watermark text also, now it reflects the foreground set on the textbox/passbox "parent".
See screenshots below, the first one illustrates the (metro demo) passwordbox, having the foreground set to white, but this isn't reflected in the watermark text, it is still black:
watermark_before

After the bug fix, it looks like this:
watermark_after

The PR handles both textboxes and passwordboxes.

ghost pushed a commit that referenced this pull request Jan 22, 2013
The cleartext button in the passwordbox doesn't match the one in a textbox
@ghost ghost merged commit 7f36ea5 into MahApps:master Jan 22, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant