Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DataGrid column styling #3672

Merged
merged 7 commits into from
Nov 4, 2019
Merged

Improve DataGrid column styling #3672

merged 7 commits into from
Nov 4, 2019

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Nov 3, 2019

Describe the changes you have made to improve this project

  • Add new TextBox editing style MahApps.Styles.TextBox.DataGrid.Editing for DataGridTextColumn
  • Add new ComboBox editing style MahApps.Styles.ComboBox.DataGrid.Editing for DataGridComboBoxColumn
  • Add a new attached DP CellPadding. This allows changing the cell padding in a simple way.
  • Add a new attached DP ColumnHeaderPadding. This allows changing the column header padding in a simple way.
  • Add a new attached DP AutoGeneratedCheckBoxColumnStyle and AutoGeneratedCheckBoxColumnEditingStyle with default style MahApps.Styles.CheckBox.DataGrid
  • Add a new attached DP AutoGeneratedTextColumnEditingStylewith default style MahApps.Styles.TextBox.DataGrid.Editing

Breaking Change

  • Remove DataGridRowHelper and DataGridCellHelper, move attached DP SelectionUnit to DataGridHelper

Closed Issues

Closes #3667

- Add new TextBox editing style `MahApps.Styles.TextBox.DataGrid.Editing`
This allows changing the cell padding in a simple way.
This allows changing the column header padding in a simple way.
@punker76 punker76 added this to the 2.0.0 milestone Nov 3, 2019
@punker76 punker76 self-assigned this Nov 3, 2019
…eckBoxColumn element styling

- New attached DP `AutoGeneratedCheckBoxColumnStyle` and `AutoGeneratedCheckBoxColumnEditingStyle` with default style `MahApps.Styles.CheckBox.DataGrid`
…lumn element styling

- New attached DP `AutoGeneratedTextColumnEditingStyle`with default style `MahApps.Styles.TextBox.DataGrid.Editing`
@punker76 punker76 changed the title WIP Improve DataGrid column styling Improve DataGrid column styling Nov 4, 2019
@punker76 punker76 merged commit 81f2a36 into develop Nov 4, 2019
@punker76 punker76 deleted the DataGrid_Column_styling branch November 4, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Datagrid TextColumn does not get styled
2 participants