Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SplitButton contents disappearing on subsequent clicks #3675

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Nov 5, 2019

Describe the changes you have made to improve this project

Derive SplitButton from ComboBox to fix disappearing Items. Implementing only the interesting stuff from the ComboBox is not possible because of too many internal things.

  • Derive from ComboBox
  • IsExpanded DP is now IsDropDownOpen
  • Remove ListBoxStyle DP
  • The SplitButton template uses now an ItemsPresenter like the ComboBox instead a full ListBox
  • The IsEditable property will be ignored and is always set to false
  • Update documentation

Closed Issues

Closes #3513

Derive SplitButton from ComboBox to fix disappearing Items. Implementing only the interesting stuff from the ComboBox is not possible because of too many internal things.

- Derive from ComboBox
- `IsExpanded` DP is now `IsDropDownOpen`
- Remove `ListBoxStyle` DP
- The `SplitButton` template uses now an ItemsPresenter like the ComboBox instead a full ListBox
- The `IsEditable` property will be ignored and is always set to false
@punker76 punker76 added this to the 2.0.0 milestone Nov 5, 2019
@punker76 punker76 merged commit 628285b into develop Nov 5, 2019
@punker76 punker76 deleted the 3513_SplitButton_Items_disappear_from_control branch November 5, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

SplitButton contents disappearing on subsequent clicks
1 participant