Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [WIP] Color Picker Control #3710

Closed
wants to merge 45 commits into from
Closed

Conversation

timunie
Copy link
Collaborator

@timunie timunie commented Dec 8, 2019

Describe the changes you have made to improve this project
Introduce a new ColorCanvas - Control. With this Control we can build a ColorPicker in the future.

Still to do:

  • improve eyepicker
  • Implement a ColorPalette
  • Create a ColorPickerComboBox

Unit test
None until now

Additional context

Add any other context or screenshots about the feature request here.
image

Closed Issues
Part solution for #3520

@timunie
Copy link
Collaborator Author

timunie commented Dec 8, 2019

@punker76 One more thing is that we need to make the lables translateable. I like Resx files for this but maybe this is not easy enough to translate for others.

@timunie
Copy link
Collaborator Author

timunie commented Dec 20, 2019

Improved the EyeDropper:

  • Moved it to a separate Control named ColorEyeDropper. That way you can use it without any ColorPicker.
  • Control displays now a zoomed Image

see it in Action:
EyeDropperInAction

Happy coding and Merry X-Mas,
Tim

@timunie
Copy link
Collaborator Author

timunie commented Apr 20, 2020

Current status:

  • Added a ColorListBox
  • Changed the Style of the Sliders for better control over color selection
  • added a way to type color names (english / translated / hex)

ColorPicker_Preview

Happy coding
Tim

@timunie timunie changed the title [WIP] Color Canvas Control [WIP] Color Picker Control Apr 27, 2020
@timunie
Copy link
Collaborator Author

timunie commented Apr 27, 2020

Current Status:

implemented some build in ColorPalettes and a way to store recent colors
ColorPicker_Preview

@timunie
Copy link
Collaborator Author

timunie commented Jun 9, 2020

Current state:
I implemented almost all the stuff I wanted to (or better said: I was able to). Now there are some issues to solve and decisions to make which I am not able to do without support:

  • What about the Styles for the Sub-Controls (e.g. EyeDropper, Slider) should one be able to change them?
    • EyeDropper
    • Slider
    • NumericUpDown
    • TextBox
    • TabControl
    • TabItems
  • Should the user be able to choose wether to show Palettes and / or the custom CustomColor
  • Should the control automatically add to recent color and if yes, which should be the trigger? Popup closed or color changed?
  • The popups StaysOpen Property does not always fire
  • Should the alpha channel be able to get disabled?
  • Should the HSV channels be able to get disabled?

timunie and others added 24 commits August 27, 2020 09:10
- Ability to Add as many ColorPallets as whished
- Ability to use ColorCanvas to select a custom Color
- Some more improvements
- Standard Colors
- WPF Colors
- Example with a custom tinted palette
- Implement a DropDownOpened / -Closed Event
- Implement a ObservableCollection for RecentColors
- Implement a Helper to set RecentColors
- Add test
- Simplify conversion
- More precise calculation
- Added a way to translate the Labels
- This way we can provide the ColorNamesDictionary via Binding
- Implemented a Color Palette in the Demo with the MahApps-Accents (Named, see Tooltip)
- Note: When the Converter is used in MultiBinding, There is no ConvertBack available.
- You can now add a Watermark
- You can now clear the selected color. It will either set null or (if definied) use the default color
- Close on mouse down outside ColorPicker
- Focus on ColorPalette when opening 
- Change the way ColorPalettes were implemented (Max. 5 Palettes can be used)
Update the preview image from the Background Threat to improve usability
@timunie
Copy link
Collaborator Author

timunie commented Oct 2, 2020

I will close this PR because there is a new (cleaner) one available right now. See #3930

@timunie timunie closed this Oct 2, 2020
@timunie timunie deleted the ColorPicker branch November 11, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants