Listview listbox item selected #385
Conversation
|
I renamed the border control to fit the ListBoxItem style, but it's not really necessary. No matter what will happen to the White color it has also to be changed in some other controls. For example: I think setting a "AccentForegroundColor" for each color would be the best way, because it's easier to customize if you want to add a custom color where white wouldn't fit. |
|
Yes, definitely change it gradually across all the controls. What about AccentSelectedForegroundColor? From: stefan-schweiger I renamed the border control to fit the ListBoxItem style, but it's not really necessary. No matter what will happen to the White color it has also to be changed in some other controls. For example: I think setting a "AccentForegroundColor" for each color would be the best way, because it's easier to customize if you want to add a custom color where white wouldn't fit. — |
|
Accent Selected ForegroundColor doesn't really fit, because it's not always used for selected items (like in the two examples in my previous comment) |
|
Sure, but I'd like the name to be as specific as possible. I'll look at those cases asap, I'd like to close out this and #386 and ship a new preview today/tomorrow. |
I'd rather not introduce sweeping changes at this point (we really need a stable release) but I'll keep that in mind for the future. |
|
Ok, that's enough changes and cleanup for one day. If there's no further objections to the changes I'll push it up tomorrow. |
The selected item should have a white foreground to match other controls as groupboxes.
…side ListBox/ListView
Supersedes #380 as:
TODO: