Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for Merge] Implemented a FlipView control. #472

Merged
merged 12 commits into from
May 25, 2013

Conversation

AzureKitsune
Copy link
Member

Implemented a simple FlipView control based on the one in Windows Store Apps (Windows 8/RT Metro Apps).

Based on the Selector control (like it's W.S.A. counterpart) and uses the TransitioningContentControl at it's core.
m2
m1

  • Implement base control.
  • Implement a banner.
  • Change arrows.
  • Implement any feedback provided by others: (See below)
  • Don't show banner if BannerText is null. Invalid because FlipView is trying to emulate it's W8 counterpart.
  • The appropriate control button disables if it cannot be used depending on SelectedIndex.
  • Further emulate Windows 8 behavior by keeping Banner shown as long as IsBannerEnabled is true.

@ghost ghost assigned AzureKitsune May 24, 2013
@AzureKitsune
Copy link
Member Author

I have taken the liberty to implement a banner which slides up from the bottom of the control to display text. The BannerText property is bindable.
m

@shiftkey
Copy link

A few little things:

When at the start of the list, the left button should not be visible. Same thing with the end and the right button.

Banner message:

  • should it show up on start and every transition? I like how Instagram does their banner message - it fades in when you hover over it.
  • should the banner message be visible if it isn't set?

@shiftkey
Copy link

Put the demo on the second row so you can get some space for the banner text (currently partially cut off)

image

And make the banner enabled by default

@AzureKitsune
Copy link
Member Author

Banner is now enabled by default. If I put the FlipView, it would be the same result unless I change the RowHeight. I made it span 2 rows instead, for now.

@AzureKitsune
Copy link
Member Author

More bugs have been discovered. This may take longer than I thought.

@AzureKitsune
Copy link
Member Author

Ready for merging.

AzureKitsune added a commit that referenced this pull request May 25, 2013
Implemented a FlipView control.
@AzureKitsune AzureKitsune merged commit 9453540 into MahApps:master May 25, 2013
@AzureKitsune AzureKitsune deleted the flipview branch May 25, 2013 23:59
@damced
Copy link

damced commented Nov 20, 2014

In Flip, focus show like a gray border over the control when mouse is over a child control. How can hide that border?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants