-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessageBox #657
MessageBox #657
Conversation
@DharmeshPatel33 |
ohhh , Thanks @flagbug , i will fix it and again pulled it, |
I can't wait to test this. |
Tested. A few things:
|
as per @punker76 requirement vertically centered |
i prefer the "box" centered but the width i prefer 200-400 not the window complete |
@DharmeshPatel33 Since no progress has been made on #550, could you make it so that the messagebox blurs (or darkens) the window? |
It's getting there. The button needs to be inverted color-wise. White messagebox needs a black button with white text. |
hello @Amrykid, are you addressing this changes?? |
@DharmeshPatel33 Yes I am. Looking good. |
@DharmeshPatel33 Can you please remove the regions and unnecessary newlines? |
The proportions still seem a little bit off in my opinion. There should be thicker margins above the title and below the button. Also the margin between text and button looks a bit to thick. |
Oh and I'm not quite sure about the black border, I think it would be better without one, like in the screenshot @Amrykid provided. |
@flagbug @Amrykid @shiftkey @Cornyfisch @DharmeshPatel33 @stefan-schweiger hi, we have now 3 issues with Metro Dialogs. #657 #550 #615 my suggestion is, MahApps.Metro should not have any Metro Dialogs implementation! why? because there are too many people who have different ideas about it. the first one like this, the second one not, the next one likes that, other people do not and so on... what do you think? best regards Jan |
Metro Style messageBox