Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageBox #657

Closed
wants to merge 6 commits into from
Closed

Conversation

DharmeshPatel33
Copy link

Metro Style messageBox

@flagbug
Copy link
Member

flagbug commented Sep 9, 2013

@DharmeshPatel33 MessageBox is often misspelt as MessegeBox in your code

@DharmeshPatel33
Copy link
Author

ohhh , Thanks @flagbug , i will fix it and again pulled it,

@AzureKitsune
Copy link
Member

I can't wait to test this.

@AzureKitsune
Copy link
Member

Tested. A few things:

  1. It would nice with some sort of 'flipping'-in animation along with a 'flipping'-out animation.
  2. Similar to Added a MetroPopup that can also be used like a Message Box #550

@flagbug or @punker76 Any input?

@punker76
Copy link
Member

  1. the message box is not vertically centered in main window if maximised

image

  1. subobjektiv considered, i don't like such message box style, sorry
  2. should it be possible to blur the mainwindow?

@AzureKitsune
Copy link
Member

@punker76 #550 darkens the window, if that's what you're referring to. Blurring should be the same process.

@DharmeshPatel33
Copy link
Author

as per @punker76 requirement vertically centered

messagebox

@spiritdead
Copy link
Contributor

i prefer the "box" centered but the width i prefer 200-400 not the window complete

@AzureKitsune
Copy link
Member

@DharmeshPatel33 Since no progress has been made on #550, could you make it so that the messagebox blurs (or darkens) the window?

Sort of like this:
img

@DharmeshPatel33
Copy link
Author

hello @Amrykid and @punker76 ,
What you say about this?. still any changes required ?
messagebox

@AzureKitsune
Copy link
Member

It's getting there. The button needs to be inverted color-wise. White messagebox needs a black button with white text.

@DharmeshPatel33
Copy link
Author

Button style inverted.
Default Black,
Over GrayBrush5,
Pressed White.

messagebox

@AzureKitsune
Copy link
Member

✨ Awesome.

Could you replicate the styling and positioning of 'title' as shown the pic below?
img

After that, it will be ready for merging.

@DharmeshPatel33
Copy link
Author

hello @Amrykid, are you addressing this changes??
messagebox

@AzureKitsune
Copy link
Member

@DharmeshPatel33 Yes I am. Looking good.

@flagbug
Copy link
Member

flagbug commented Oct 10, 2013

@DharmeshPatel33 Can you please remove the regions and unnecessary newlines?

@jessestricker
Copy link

The proportions still seem a little bit off in my opinion. There should be thicker margins above the title and below the button. Also the margin between text and button looks a bit to thick.

@jessestricker
Copy link

Oh and I'm not quite sure about the black border, I think it would be better without one, like in the screenshot @Amrykid provided.

@punker76
Copy link
Member

@flagbug @Amrykid @shiftkey @Cornyfisch @DharmeshPatel33 @stefan-schweiger

hi,

we have now 3 issues with Metro Dialogs. #657 #550 #615

my suggestion is, MahApps.Metro should not have any Metro Dialogs implementation!

why?

because there are too many people who have different ideas about it. the first one like this, the second one not, the next one likes that, other people do not and so on...
let the people do their own thing, maybe as addon or similar.

what do you think?

best regards

Jan

@AzureKitsune AzureKitsune mentioned this pull request Nov 2, 2013
20 tasks
@flagbug flagbug closed this Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants