Close flyout when clicking outside of it #965

zeluisping · 2014-01-20T14:51:59Z

PreviewMouseDown on MetroWindow which tries to find a Flyout parent, if it does not exist, then close the open flyouts.

PreviewMouseDown on flyoutModal to close modal flyouts when clicking on the darken area.

Fix_es #962
Should not be merged: #1000

PreviewMouseDown on MetroWindow which tries to find a Flyout parent, if it does not exist, then close the open flyouts. PreviewMouseDown on flyoutModal to close modal flyouts when clicking on the darken area.

AzureKitsune · 2014-01-20T14:57:24Z

Could we add a property for enabling this feature? We don't want to break things.

zeluisping · 2014-01-20T14:58:11Z

Yup, no problem.

flagbug · 2014-01-20T15:01:34Z

I'm not sure if this should be the default behavior, how about a flag in the Flyout control class that indicates if the flyout should be automatically closed?

Also this implementation currently responds to a left or right click, maybe we should make this customizable, so the developer can select if the flyout should handle the left, right or any mousebutton

flagbug · 2014-01-20T15:02:06Z

@Amrykid You beat me to it

zeluisping · 2014-01-20T15:04:42Z

@flagbug Yeah, totally forgot about that.

topvis · 2014-01-20T15:06:40Z

Just curious, is IsPinnable property originally reserved for this purpose?

AzureKitsune · 2014-01-20T15:09:27Z

.... Probably. That's a good idea.

Added properties for closing on mouse click.

Removed CloseOnExternalClick. Renamed ExternalClickMouseButton to NotPinnableCloseButton.

flagbug · 2014-01-20T15:22:26Z

Some ideas: Rename IsPinnable to IsPinned and make the default value true
That's a breaking change but IsPinnable didn't even had a use, so it should be fine

The name NotPinnableCloseButton is a bit confusing, we should find a better name for this, maybe ExternalCloseButton ?

topvis · 2014-01-20T15:22:41Z

I was guessing if IsPinnable was reserved for this purpose. But I would prefer to use a new property IsAutoClose. IsPinnable by name shows whether the flyout has the capability of being pinned or not, not necessisarily pinned or not.

topvis · 2014-01-20T15:25:25Z

@flagbug same idea here. IsPinned (or IsAutoClose) is better than IsPinnable.

Renamed IsPinnable to IsPinned and set it's default value to true.

Renamed NotPinnableCloseButton to ExternalCloseButton.

Added the ability to customize the mouse button that hides flyouts when Flyout::IsPinned is false.

Added OverrideIsPinned to be able to make all flyouts behave as if IsPinned is set to false (even if it is set to true).

Added functionality for FlyoutsControl::OverrideIsPinned, which makes all Flyouts behave as if IsPinned is set to false.

zeluisping · 2014-01-20T15:45:24Z

@flagbug It is now ready for a review.

I also added the property OverrideIsPinned to FlyoutsControl that makes all flyouts behave as if IsPinned is set to false (with default value of false).

flagbug · 2014-01-20T15:47:12Z

🆒 can you add some descriptive XML docs for the properties respectively update the doc for IsPinned ?

flagbug · 2014-01-20T15:50:33Z

MahApps.Metro/Controls/FlyoutsControl.cs

+        public static readonly DependencyProperty OverrideIsPinnedProperty =
+            DependencyProperty.Register("OverrideIsPinned", typeof(bool), typeof(FlyoutsControl), new PropertyMetadata(false));
+
+        public MouseButton ExternalCloseButton


Can we make this the same as IsPinned?

ExternalCloseButton as property for each individual flyout and OverrideExternalCloseButton for FlyoutControl?

zeluisping · 2014-01-20T15:55:40Z

@flagbug Yes, totally, I'm just going to eat lunch real quick.

Added ExternalCloseButton and updated documentation.

Replaced ExternalCloseButton with OverrideExternalCloseButton. Added documentation to OverrideIsPinned and OverrideExternalCloseButton.

Added implementation for FlyoutsControl::OverrideExternalCloseButton and Flyout::ExternalCloseButton.

zeluisping · 2014-01-20T19:01:35Z

@flagbug It's ready for another review.

flagbug · 2014-01-20T19:25:52Z

Looks good 👍

flagbug · 2014-01-20T19:34:18Z

Cool, so if there aren't any objections, I'm gonna merge this

flagbug · 2014-01-20T19:35:18Z

Ah wait, our development model is a bit stupid. Have to wait for this till 0.12.1 is built

…ors if the upper flyout is closing

Fixes issue #988

We introduce the property "OverrideDefaultWindowCommandsBrush" that is default by null. CleanWindowStyle ovverides this to "BlackBrush" This fixes #990

Fixes #995

Strange, I thought everything was indented correctly...

Added ExternalCloseButton and updated documentation.

zeluisping · 2014-02-03T21:33:04Z

#1000 Replaces this.

Close Flyouts with external click (makes #965 obsolete)

Close flyout when clicking outside of it

60cb756

PreviewMouseDown on MetroWindow which tries to find a Flyout parent, if it does not exist, then close the open flyouts. PreviewMouseDown on flyoutModal to close modal flyouts when clicking on the darken area.

zeluisping added 2 commits January 20, 2014 15:10

CloseOnExternalClick and ExternalClickMouseButton

9402143

Added properties for closing on mouse click.

Switched to using Flyout::IsPinnable

df4abc4

Removed CloseOnExternalClick. Renamed ExternalClickMouseButton to NotPinnableCloseButton.

zeluisping added 5 commits January 20, 2014 15:28

IsPinnable renamed to IsPinned

1122e7d

Renamed IsPinnable to IsPinned and set it's default value to true.

NotPinnableCloseButton -> ExternalCloseButton

b11e33a

Renamed NotPinnableCloseButton to ExternalCloseButton.

Updated behaviour, fixed formatting

a717756

Added the ability to customize the mouse button that hides flyouts when Flyout::IsPinned is false.

Added OverrideIsPinned

b2d286f

Added OverrideIsPinned to be able to make all flyouts behave as if IsPinned is set to false (even if it is set to true).

Added functionality for OverrideIsPinned

8b539a7

Added functionality for FlyoutsControl::OverrideIsPinned, which makes all Flyouts behave as if IsPinned is set to false.

flagbug reviewed Jan 20, 2014
View reviewed changes

topvis mentioned this pull request Jan 20, 2014

Auto-close flyout #962

Closed

zeluisping added 3 commits January 20, 2014 18:19

Documentation, ExternalCloseButton

fe186e1

Added ExternalCloseButton and updated documentation.

Documentation + OverrideExternalCloseButton

434e883

Replaced ExternalCloseButton with OverrideExternalCloseButton. Added documentation to OverrideIsPinned and OverrideExternalCloseButton.

OverrideExternalCloseButton + ExternalCloseButton

d91fe37

Added implementation for FlyoutsControl::OverrideExternalCloseButton and Flyout::ExternalCloseButton.

flagbug and others added 24 commits February 3, 2014 20:35

Create the ultimate hack so we can "Run All" tests

155d33e

Clean window tests

8006e2d

More tests

501b2f2

Assert that the underlying flyout sets the correct window command col…

686c418

…ors if the upper flyout is closing

Fix test

36d1101

Respond to changes of the "Theme" property of a Flyout

bf42fa7

ControlTemplate did not respect Flyout's Margin

743fc8c

fix finding real flyout control - take two

31c9eb7

IRC is dumb, we're moving to Gitter

7f25074

Fixes issue #988

Fix typo

004f6b8

Clarify that your unit test runner will never speak with you again

5da0098

Fix some of the tests

abdcf69

Fix some tests

6b384ab

Reproduce #990

c71968e

Minor cleanups

9c85eac

Simplify the WindowCommands handling for the clean window style

39014df

We introduce the property "OverrideDefaultWindowCommandsBrush" that is default by null. CleanWindowStyle ovverides this to "BlackBrush" This fixes #990

Update release notes

aa3d272

Update NuGet

cb78669

Fix the build

8d1c663

Fixes #995

publish 0.12.1

9ea831f

fixing external dialogs (fixes #994)

f60a24a

naming

dcc2851

Indentation fixed

0079634

Strange, I thought everything was indented correctly...

Documentation, ExternalCloseButton

0958929

Added ExternalCloseButton and updated documentation.

zeluisping mentioned this pull request Feb 3, 2014

Close Flyouts with external click (makes #965 obsolete) #1000

Merged

zeluisping closed this Feb 3, 2014

zeluisping deleted the patch-4 branch February 3, 2014 21:33

AzureKitsune added a commit that referenced this pull request Feb 4, 2014

Merge pull request #1000 from 100GPing100/patch-3

0bc1094

Close Flyouts with external click (makes #965 obsolete)

zeluisping mentioned this pull request Feb 5, 2014

Fix missing flyout external click code #1011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Close flyout when clicking outside of it #965

Close flyout when clicking outside of it #965

zeluisping commented Jan 20, 2014

AzureKitsune commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

zeluisping commented Jan 20, 2014

topvis commented Jan 20, 2014

AzureKitsune commented Jan 20, 2014

flagbug commented Jan 20, 2014

topvis commented Jan 20, 2014

topvis commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug Jan 20, 2014

zeluisping commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

zeluisping commented Feb 3, 2014

Close flyout when clicking outside of it #965

Close flyout when clicking outside of it #965

Conversation

zeluisping commented Jan 20, 2014

AzureKitsune commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

zeluisping commented Jan 20, 2014

topvis commented Jan 20, 2014

AzureKitsune commented Jan 20, 2014

flagbug commented Jan 20, 2014

topvis commented Jan 20, 2014

topvis commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug Jan 20, 2014

Choose a reason for hiding this comment

zeluisping commented Jan 20, 2014

zeluisping commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

flagbug commented Jan 20, 2014

zeluisping commented Feb 3, 2014