Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete issue functionality #35

Merged
merged 4 commits into from
Mar 9, 2023
Merged

delete issue functionality #35

merged 4 commits into from
Mar 9, 2023

Conversation

bic-marz
Copy link
Contributor

@bic-marz bic-marz commented Mar 3, 2023 •
edited
Loading

to-fix IssueCard.tsx, zIndex and dimension of the menu component

also renamed and fixed the deleteSubtask, in jiraCloudProvider, which is now called deleteIssue

@bic-marz bic-marz marked this pull request as ready for review March 4, 2023 11:59
@IhsenBouallegue
Copy link
Collaborator

Looks good we can imporove:

  • the margin of the divider (on the right)
  • the delete button ui (remove menu)
  • show delete button on hover
  • optional: make a generic delete button

@bic-marz bic-marz merged commit 5f4701a into main Mar 9, 2023
@bic-marz bic-marz deleted the delete-issue branch March 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oussema18 oussema18 oussema18 approved these changes

@IhsenBouallegue IhsenBouallegue IhsenBouallegue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bic-marz @IhsenBouallegue @oussema18