Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show folder names as labels on the floor #1491

Closed
ce-bo opened this issue Nov 18, 2020 · 2 comments · Fixed by #1521
Closed

Show folder names as labels on the floor #1491

ce-bo opened this issue Nov 18, 2020 · 2 comments · Fixed by #1521
Assignees
@shaman-apprentice @ce-bo
Labels
difficulty:hard It is quite difficult to get a working solution feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Nov 18, 2020 •
edited
Loading

Feature request

Description

As a an Auditor, I want to see the name of the folder on the floor on which a specific building is placed, so that I can see where a specific software module is placed without any clicks.

Acceptance criteria

  • The first 3 floor layers are labeled with the name of the folder that the individual layer represents.
  • The label is fixed just like the floor geometric (just like the floor would be stamped).
  • The deeper the layer the smaller the font size is.
  • The folder name is centered vertically

Development notes (optional Task Breakdown)

  • We must expand the floor geometric on the front side to have enough space for the folder name to be placed.

Example

Here you can find a 2D example of labeled floors: https://observablehq.com/@d3/nested-treemap?collection=@d3/d3-hierarchy
@ce-bo ce-bo added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:high Set by PO feature Feature requests difficulty:hard It is quite difficult to get a working solution labels Nov 18, 2020
@shaman-apprentice shaman-apprentice self-assigned this Nov 20, 2020
@Richargh
Copy link

@shaman-apprentice I don't know if this is relevant for your task, but I researched algorithms to create non-overlapping labels in issue #334. I'm afraid it's not more than that though, just a possible starting point.

@Richargh Richargh mentioned this issue Nov 20, 2020
Open
@ce-bo
Copy link
Collaborator Author

ce-bo commented Nov 20, 2020

Thank you @Richargh . That might be relevant for #1347. We are implementing another algorithm at the moment.

ce-bo added a commit that referenced this issue Nov 25, 2020
@ce-bo
Add logic to place folder names onto the first 3 floor layers #1491
7d6df39
ce-bo added a commit that referenced this issue Nov 25, 2020
@ce-bo
Add more space for the floor labels (this causes buildings to dissape…
39e4763 
…ar unfortunately) #1491
ce-bo added a commit that referenced this issue Nov 26, 2020
@ce-bo
Adjust label font sizes and paddings #1491
01ecab4
@ce-bo ce-bo self-assigned this Nov 26, 2020
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Fix missing labels due to wrong font size retrival #1491
e414779
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Remove debug helping condition #1491
a2fcb66
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Add notes to improve the code readability/understandability #1491
44ad4ae
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Fix minor bugs #1491
08783ff
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Add a scale factor to decrease needed pixels to be rendered (fix perf…
4471719 
…ormance issue) #1491
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Adjust label floor paddings, Render floor label for the first 4 layers …
847eb4b 
…#1491
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Add dynamic map resolution scaling factor #1491
c273a88
@ce-bo ce-bo mentioned this issue Nov 27, 2020
Merged
ce-bo added a commit that referenced this issue Nov 27, 2020
@ce-bo
Fix Unit Tests #1491
070ab0b
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Add color effects to folder labels #1491
4e90cba
RomanenkoVladimir added a commit that referenced this issue Nov 27, 2020
@RomanenkoVladimir
Refactor color calculation #1491
5c744c5
ce-bo added a commit that referenced this issue Nov 28, 2020
@ce-bo
Adjust paddings, Scale Font Size, Shorten label text #1491
4a9c3dc
ce-bo added a commit that referenced this issue Nov 28, 2020
@ce-bo
Fix Unit Tests #1491
b0c5062
ce-bo added a commit that referenced this issue Nov 28, 2020
@ce-bo
Fix Unit Tests #1491
a543d78
ce-bo added a commit that referenced this issue Nov 28, 2020
@ce-bo
Add some todos, Apply format/code style #1491
81df684
ce-bo added a commit that referenced this issue Nov 28, 2020
@ce-bo @RomanenkoVladimir
Feature/1491/place package name on floor (#1521)
49986c7 
* Update node version '8' to '>= 8'

* Remove section 'Install web application on server'

As how to host static server is not scope of this readme. Neither has it surprising obstacles.

* Update some obsolete task entries

* Fix `npm run plop`

Through updating dependencies of "@types/jest-environment-puppeteer"-dependency - Previously jest-environment-node@26.6.2 and jest-environment-node@26.5.2 were required in package-lock.json

* Specify the need to build web before running e2e

* Correct e2e execution command for visualization

* Remove obsolete hint to Slack channel

* Add a optional performance question

* Play a little around with a starting point for further playaround

* Add some incomplete rotation

* Add logic to place folder names onto the first 3 floor layers #1491

* Add more space for the floor labels (this causes buildings to dissapear unfortunately) #1491

* Restore changes done for debugging / understanding the code base

* Delete unused source code

* Adjust label font sizes and paddings #1491

* Fix missing labels due to wrong font size retrival #1491

* Remove debug helping condition #1491

* Add notes to improve the code readability/understandability #1491

* Abbreviate floor label if it is too long

And some lint:fix formatting

* Fix minor bugs #1491

* Refactor two linting improvements

* Add a scale factor to decrease needed pixels to be rendered (fix performance issue) #1491

* Adjust label floor paddings, Render floor label for the first 4 layers #1491

* Add dynamic map resolution scaling factor #1491

* Fix Unit Tests #1491

* Add color effects to folder labels #1491

* Refactor color calculation #1491

* Fix tests

* Adjust paddings, Scale Font Size, Shorten label text #1491

* Fix Unit Tests #1491

* Fix Unit Tests #1491

* Add some todos, Apply format/code style #1491

Co-authored-by: Torsten Knauf <Torsten.Knauf@maibornwolff.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
ce-bo added a commit that referenced this issue Dec 8, 2020
@ce-bo
Add tests, Fix minor bugs, Apply refactorings #1491
db9e8f5
@ce-bo ce-bo mentioned this issue Dec 9, 2020
Merged
ce-bo added a commit that referenced this issue Dec 9, 2020
@ce-bo
Adjust Changelog #1491, #1472
a254b40
ce-bo added a commit that referenced this issue Dec 9, 2020
@ce-bo
Add tests, Fix minor bugs, Apply refactorings #1491 (#1571)
75c6af9 
* Add tests, Fix minor bugs, Apply refactorings #1491

* Adjust Changelog #1491, #1472
@BridgeAR BridgeAR mentioned this issue Nov 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaman-apprentice shaman-apprentice

@ce-bo ce-bo

Labels
difficulty:hard It is quite difficult to get a working solution feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1491/place package name on floor MaibornWolff/codecharta
3 participants
@shaman-apprentice @ce-bo @Richargh