Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install on mac m1 #3253

Closed
xndlnk opened this issue Mar 21, 2023 · 6 comments
Closed

Cannot install on mac m1 #3253

xndlnk opened this issue Mar 21, 2023 · 6 comments
Labels
bug Only issues that describe bugs.

Comments

@xndlnk
Copy link

xndlnk commented Mar 21, 2023

Bug

Expected Behavior

WHEN

I install the Desktop Visualization via npm i codecharta-visualization locally

THEN

the application should install

Actual Behavior

I get the error message:

npm ERR! code 1
npm ERR! path /Users/xxx/Projects/toys/codecharta/node_modules/codecharta-visualization/node_modules/nw
npm ERR! command failed
npm ERR! command sh -c -- node scripts/install.js
npm ERR! Response code 404 (Not Found)

Steps to Reproduce the Problem

  1. npm i codecharta-visualization

Specifications

  • CodeCharta Version: 1.114.0
  • OS: MacOS 13.2.1 running on an Apple M1 Pro
  • Browser: Chrome Version 111.0.5563.64

Workaround

Maybe this helps to find a solution.

@xndlnk xndlnk added the bug Only issues that describe bugs. label Mar 21, 2023
@phanlezz
Copy link
Collaborator

Thanks for the bug report! We are aware of this issue with NW. There is already an open PR, that they need to merge to fix this issue.
I don't think that there is an elegant way for us to include this workaround, because it is an installation error.
I will move the workaround instructions from the Build-it-yourself section further up, so that they are more prominently displayed.

@NearW
Copy link
Contributor

NearW commented Mar 24, 2023

We do not support Silicon chips in our NWJS builds yet. Please add the correct platform to our platform list.

https://github.com/MaibornWolff/codecharta/blob/main/visualization/script/build-nwjs.js

Update platforms from:
platforms: ["osx64", "win32", "win64", "linux32", "linux64"]
to
platforms: ["osx64", "osarm64", "win32", "win64", "linux32", "linux64"]

@phanlezz
Copy link
Collaborator

phanlezz commented Apr 6, 2023

To include an arm build we need to switch to the next major version of nw-builder.
Sadly, the next major version is not yet ready for production, because there are several issues, which renders it not applicable for codecharta.
As soon as it is in a more stable state for building we will update our package script.

@NearW
Copy link
Contributor

NearW commented Apr 6, 2023

Electron suppports arm64. We can also think about switching to electron..

@phanlezz
Copy link
Collaborator

phanlezz commented Nov 2, 2023

@xndlnk With new release of version 1.120.0 Codecharta now has native ARM support, feel free to try it out! 🚀

@phanlezz
Copy link
Collaborator

phanlezz commented Nov 3, 2023

Closed via #3373 #3389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs.
Projects
None yet
Development

No branches or pull requests

3 participants