Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3253/electron build #3389

Merged
merged 12 commits into from
Nov 2, 2023
Merged

Fix/3253/electron build #3389

merged 12 commits into from
Nov 2, 2023

Conversation

phanlezz
Copy link
Collaborator

Electron Build Scripts

This adds a set of custom build scripts, which download, build and package the newly included electron desktop app for various platforms. Also includes --local flag to enable a build only for the developer's current OS & architecture combination.

Packaging might require admin rights.

Issue: #3253

Description

  • Prohibits the race condition which could occur during parallel download by pre-downloading the checksum values
  • Enables building on GitHub UNIX system by excluding mac-universal builds, which can only be build on MacOS
  • Provides local build option for quick developer testing
  • Includes clearing of download, build and application folders

@phanlezz phanlezz requested a review from ce-bo October 31, 2023 14:37
ce-bo
ce-bo approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@phanlezz phanlezz enabled auto-merge (squash) November 2, 2023 10:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz merged commit 043e774 into main Nov 2, 2023
7 checks passed
@phanlezz phanlezz deleted the fix/3253/electron-build branch November 2, 2023 10:32
@phanlezz phanlezz mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phanlezz @ce-bo