Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech: extend eslint config with recommended configs #878

Closed
NearW opened this issue Mar 11, 2020 · 2 comments
Closed

Tech: extend eslint config with recommended configs #878

NearW opened this issue Mar 11, 2020 · 2 comments
Assignees
@NearW
Labels
tech For technical stories without user impact (=refactoring stories).

Comments

@NearW
Copy link
Contributor

NearW commented Mar 11, 2020 •
edited
Loading

Feature request

Description

As a developer, I want to enforce best practices with recommended rulesets. This can be done by replacing the current extend block of the eslint config with

"extends": ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended", "prettier"]

This ruleset produces around 2000 warnings/errors at the moment.

Please do not start this issue while there are major changes going on. Once this issue is started, finish it as quick as possible before working on another issue.

This closes #826 and #865
@NearW NearW added the tech For technical stories without user impact (=refactoring stories). label Mar 11, 2020
alschmut added a commit that referenced this issue Apr 11, 2020
@alschmut
Add recommended eslint rule sets and disable mismatching rules tempor…
dede196 
…arily #878
@alschmut alschmut mentioned this issue Apr 11, 2020
Merged
11 tasks
alschmut added a commit that referenced this issue Apr 11, 2020
@alschmut
Update eslintrc comments #878
e9c224e
NearW added a commit that referenced this issue Apr 16, 2020
@NearW
Add no-console rule #878
2f33bc0
alschmut added a commit that referenced this issue Apr 20, 2020
@alschmut
Apply changes to satisfy eslint rule no-prototype-builtins #878
2a87ff7
alschmut added a commit that referenced this issue Apr 20, 2020
@alschmut
Apply changes to satisfy eslint rule no-useless-escape #878
ff99587
@alschmut alschmut mentioned this issue Apr 20, 2020
Merged
11 tasks
alschmut added a commit that referenced this issue Apr 22, 2020
@alschmut
Refactor FileValidator and error message creation #878
61a209a
NearW added a commit that referenced this issue Jun 13, 2020
@NearW
Change enable no-non-null assertion rule #878
7f9e277
NearW added a commit that referenced this issue Jun 14, 2020
@NearW
Change enable no var requires rule #878
60a1c7e
NearW added a commit that referenced this issue Jun 14, 2020
@NearW
Fix typo in test #878
5b132b3
NearW added a commit that referenced this issue Jun 14, 2020
@NearW
Update more require blocks to import statements #878
28b7d08
NearW added a commit that referenced this issue Jun 14, 2020
@NearW
Move packageJson imports for version to version.ts #878
28f0054
NearW added a commit that referenced this issue Jun 14, 2020
@NearW
Remove unnecessary parse and stringify #878
5013df4
BridgeAR pushed a commit that referenced this issue Jun 14, 2020
@NearW @BridgeAR
Change enable no-non-null assertion rule #878
07fdf74
NearW added a commit that referenced this issue Jun 15, 2020
@NearW
Revert "Move packageJson imports for version to version.ts #878"
b6dc9b7 
This reverts commit 28f0054.
@NearW
Copy link
Contributor Author

NearW commented Jul 24, 2020 •
edited by BridgeAR
Loading

Plugins to use:
- [ ] https://github.com/mysticatea/eslint-plugin-node

Rule to enable:

NearW added a commit that referenced this issue Aug 13, 2020
@NearW
Add typecast after importing json #878
64fce22
NearW added a commit that referenced this issue Aug 13, 2020
@NearW
Fix wrong merges #878
4b5898e
NearW added a commit that referenced this issue Aug 13, 2020
@NearW
Fix e2e tests #878
2e1b9fa
NearW added a commit that referenced this issue Aug 13, 2020
@NearW
Add ignore all .js files with es-lint (mostly configs), use require f…
34d5b62 
…or zlib #878
NearW added a commit that referenced this issue Sep 8, 2020
@NearW
Uninstall browserify-zlib again #878
49d7874
NearW added a commit that referenced this issue Sep 8, 2020
@NearW
Update e2e guide with using build:web #878
b008d45
NearW added a commit that referenced this issue Sep 8, 2020
@NearW @BridgeAR
ESLint: enable no var requires rule (#992)
d9531d4 
* Change enable no var requires rule #878

* Fix typo in test #878

* Update more require blocks to import statements #878

* Move packageJson imports for version to version.ts #878

* Remove unnecessary parse and stringify #878

* Revert "Move packageJson imports for version to version.ts #878"

This reverts commit 28f0054.

* Add typecast after importing json #878

* Fix wrong merges #878

* Fix e2e tests #878

* Add ignore all .js files with es-lint (mostly configs), use require for zlib #878

* Uninstall browserify-zlib again #878

* Update e2e guide with using build:web #878

* Add .gz to accept property

* Update CHANGELOG

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 2, 2020

Closing as resolved

@BridgeAR BridgeAR closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NearW NearW

Labels
tech For technical stories without user impact (=refactoring stories).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BridgeAR @NearW