-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/3406/fix rawtextparser input handling 2 #3419
Fix/3406/fix rawtextparser input handling 2 #3419
Conversation
In the help (and github pages) the parameters |
The help for |
...wTextParser/src/main/kotlin/de/maibornwolff/codecharta/parser/rawtextparser/RawTextParser.kt
Outdated
Show resolved
Hide resolved
...awTextParser/src/test/kotlin/de/maibornwolff/codecharta/rawtextparser/MetricCollectorTest.kt
Show resolved
Hide resolved
...src/main/kotlin/de/maibornwolff/codecharta/parser/rawtextparser/metrics/IndentationMetric.kt
Outdated
Show resolved
Hide resolved
...extParser/src/main/kotlin/de/maibornwolff/codecharta/parser/rawtextparser/MetricCollector.kt
Outdated
Show resolved
Hide resolved
Can be solved using a paramLabel: https://picocli.info/#_parameter_labels |
This happens because picocli uses "-v" for the version flag, and it gets automatically combined with the "-h" flag. After checking the documentation, there doesn't seem to be a way to stop this, except for changing the verbose flag to something like "-ve" or a similar option. |
...awTextParser/src/test/kotlin/de/maibornwolff/codecharta/rawtextparser/MetricCollectorTest.kt
Show resolved
Hide resolved
...er/src/test/kotlin/de/maibornwolff/codecharta/rawtextparser/metrics/IndentationMetricTest.kt
Show resolved
Hide resolved
...awTextParser/src/test/kotlin/de/maibornwolff/codecharta/rawtextparser/MetricCollectorTest.kt
Show resolved
Hide resolved
887aafb
to
dfcb570
Compare
dfcb570
to
affdc47
Compare
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
Fix RawTextParser incorrectly handling the max indentation level
Issue: #3406
Description
Fix RawTextParser internally setting a new max indentation level, independent from what the user put in.
This was done by refactoring relevant code and not using internal default values anymore.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: