Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split option parameters by comma only #889 #3434

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

fritschldwg
Copy link
Contributor

@fritschldwg fritschldwg commented Dec 7, 2023

Split option parameters by comma only #889

Closes: #889

Description

  • User can now specify parameters and options in any order (except for the sonar importer which requires the url and project_id being the first parameters)
  • It is now required to separate multiple values for a single option flag by comma and without whitespace accross all parsers i.e. ccsh rawtextparser -e exclude1 exclude2 is no longer supported and is replaced with ccsh rawtextparser -e exclude1,exclude2

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@fritschldwg
Copy link
Contributor Author

@Nereboss Using a PreProcessor to fix the issue doesn't work accross platforms.
./build/install/codecharta-analysis/bin/ccsh modify -r remove_1, remove_2 out.cc.json works only in gitbash but not in other shells.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions says that whitespace is not allowed. Looking at the code it still seems to be possible to parse foo, bar properly, no?

@fritschldwg fritschldwg force-pushed the fix/889/fix-options-parameters-ordering branch from ffbd8a7 to b25cf35 Compare December 11, 2023 07:02
Copy link

sonarcloud bot commented Dec 11, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

sonarcloud bot commented Dec 11, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Nereboss Nereboss merged commit ac2b00d into main Dec 11, 2023
7 checks passed
@Nereboss Nereboss deleted the fix/889/fix-options-parameters-ordering branch December 11, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintuitive behaviour of ccsh modify
4 participants