-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reframe sonar user token question #3445
Conversation
message = "What is the sonar.login for connecting to the remote sonar instance?", | ||
hint = "c123d456" | ||
message = "What is the sonar user token (sonar.login) required to connect to the remote Sonar instance?", | ||
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda" | |
hint = "squ_a85eae3934941de66cbd0115f500aa59234afcda" // nosonar |
Maybe this can exclude it from the security check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using the token:
sqp_5a03f4395033c714f44cddfabb60fe2a65fcb4bd
in the hint, as it is one used in the sonarqube documentation about tokens (https://docs.gitguardian.com/secrets-detection/detectors/specifics/sonarqube_token)
I don't know if this would fix the quality issue but I think its a good idea to use an already public token here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this token used anywhere? If yes: please change it immediately.
5822598
to
88cfe2f
Compare
Quality Gate passed for 'CodeCharta Visualization'Kudos, no new issues were introduced! 0 New issues |
Quality Gate passed for 'CodeCharta Analysis'Kudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
All tokens used in the hint were either scrambled or publicly available example tokens - valid personal tokens were never introduced to the code |
Reframe sonar user token question
Closes: #3431
Description
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: