Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable metric-gardener until a new version is released #3542

Merged
merged 6 commits into from
Apr 10, 2024

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Apr 9, 2024

Disable metric-gardener on-the-fly execution

Because of the issues on linux under node18 with metric-gardener, the on-the-fly execution through codecharta-analysis will be disabled until a new version is released.

Issue #3541

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@phanlezz phanlezz marked this pull request as ready for review April 10, 2024 06:35
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 10, 2024

Copy link
Contributor

@fritschldwg fritschldwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phanlezz phanlezz merged commit 93f8858 into main Apr 10, 2024
7 checks passed
@phanlezz phanlezz deleted the tech/3541/metric-gardener-problems-node18-linux branch April 10, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants