Fix key handling metric chooser #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritschldwg
force-pushed
the
feature/719/keyboard-selection-metric-chooser
branch
from
c464e0d to
ccb5e2c
Compare
Nereboss
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Code quality looks good but theres one bug i found:
For some combination of inputs, the highlighting and pressing enter to select stops working.
Example:
Load the output.cc.json.gz from the assets folder
type 'c' into the selection
Press arrow down until the last element in the list is selected
type 'o' and the selection is broken, meaning arrow keys cant be used for selecting and enter does not work
fritschldwg
force-pushed
the
feature/719/keyboard-selection-metric-chooser
branch
from
8c49d6a to
182fdc3
Compare
fritschldwg
force-pushed
the
feature/719/keyboard-selection-metric-chooser
branch
from
abdc54f to
7dff0b7
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix key handling metric chooser
Closes: #719
Description
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: