Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul the Suspicious Metrics menu with Angular-17 #3612

Merged
merged 35 commits into from
Jun 3, 2024
Merged

Overhaul the Suspicious Metrics menu with Angular-17 #3612

merged 35 commits into from
Jun 3, 2024

Conversation

ViktoriaGordeevaVG
Copy link
Collaborator

@ViktoriaGordeevaVG ViktoriaGordeevaVG commented May 8, 2024 •
edited by Nereboss
Loading

Overhaul the Suspicious Metrics menu

Closes: #3493

Description

The 'Suspicious Metrics' tab has been streamlined and is now more user-friendly. Key improvements include:

  • Information about suspicious metrics is neatly concealed within an info box, accessible via click or hover for easy visibility.
  • Untracked metrics in the code are now neatly tucked away in a toggle feature, which can be expanded with a click, similar to the functionality of our file explorer.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@ViktoriaGordeevaVG ViktoriaGordeevaVG changed the title 3493 updated angular-17 Overhaul the Suspicious Metrics menu May 8, 2024
@ViktoriaGordeevaVG ViktoriaGordeevaVG changed the title Overhaul the Suspicious Metrics menu Overhaul the Suspicious Metrics menu with Angular-17 May 8, 2024
@ChristianHuehn
Copy link
Collaborator

ChristianHuehn commented May 10, 2024 •
edited by ViktoriaGordeevaVG
Loading

image

We should probably improve a couple of things:

  • Make Suspicious Metrics at the top a bit bigger so that it's a heading for the whole Metrics part
  • reduce space between "Suspicious Metrics" and "Suspicious Metrics in ts code"
  • if easily achievable, animate the arrow from accordions
  • reduce space between accordions to their content like "Unsuspcious metrics in ts code"
  • remove one level of idention of unsuspicious and untracked metricks so it feels like the following example:

Suspicious Metrics (h1)
Suspicious Metrics in ts code (h2 - identation 0)
Unsuspicious metrics in ts code (h2 - identation from 1 to 0)
Untracked metrics in ts code (h2 - identation from 1 to 0)

h1 and h2 are just examples. Use an appropriate level so that h1 feels like a header and h2 like headers for categories inside. 👍

@phanlezz phanlezz force-pushed the feature/3493/overhaul-suspicious-metrics-menu-a17 branch from b07c10d to 034b840 Compare May 27, 2024 08:32
VictoriaG and others added 24 commits May 29, 2024 09:44
@phanlezz
3493 updated angular-17
7fcf70e
@phanlezz
3493 updated angular-17 and fixed unit tests
f9ed69e
@phanlezz
3493 fix triggering by open/close mat-menu
456753e
@phanlezz
fix failed e2e ribbon bar test
58600f3
@phanlezz
fixed stylings for suspicious metrics panel
7dbc010
@phanlezz
fix suspiciuos metrics panel styling and animate arrow icons
b074ce5
@phanlezz
3493 fix buttons stylings
f44165e
@phanlezz
3493 split suspicious metric component
6db9480
@phanlezz
3493 change folder structure
36aa256
@phanlezz
3493 change folder structure
55dcf01
@phanlezz
3493 fix stylings issues
988a67b
@phanlezz
#3493 update syntax angular-17 and remove hooks from suspicious metri…
b3ba9ee 
…c buttons
@phanlezz
implement suspicious buttons closing mat menu
70f260f
@phanlezz
Add changelog entry back in, change issue number to pr number
e3f9edc
@phanlezz
Apply prettier
62c07df
@phanlezz
Add some styling WIP
4fb422f
@phanlezz
Adjust dialog button, font color, add link icon
487b801
@phanlezz
Re-remove toggle behaviour of button group
3da7ace
@phanlezz
Change style of untracked and unsuspicious metric list
bf99c6b
@phanlezz
Change button to i fa with role button
20c07e5
@phanlezz
Fix e2e test by updating selector
adb23bc
@phanlezz
Fix test by updating selectors and swapping to
dc91181 
title selectors
@phanlezz
Add noopener to links as described by sonar
a42bc51
@phanlezz
Change table to grid layout
6e12e94
@phanlezz phanlezz force-pushed the feature/3493/overhaul-suspicious-metrics-menu-a17 branch from c9baf98 to 6e12e94 Compare May 29, 2024 07:44
@phanlezz phanlezz requested a review from Nereboss May 29, 2024 07:46
Nereboss
Nereboss approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller changes that should be incorporated before merging. Nonetheless early LGTM

...odeCharta/ui/ribbonBar/artificialIntelligence/highRiskProfile/highRiskProfile.component.html Outdated Show resolved Hide resolved
...ta/ui/ribbonBar/artificialIntelligence/suspiciousMetrics/suspiciousMetrics.component.spec.ts Outdated Show resolved Hide resolved
...iousMetrics/suspiciousMetricsMenu/susoiciousMetricsList/suspiciousMetricsList.component.html Outdated Show resolved Hide resolved
...iciousMetrics/suspiciousMetricsMenu/susoiciousMetricsList/suspiciousMetricsList.component.ts Show resolved Hide resolved
...ialIntelligence/suspiciousMetrics/suspiciousMetricsMenu/suspiciousMetricsMenu.component.html Outdated Show resolved Hide resolved
@phanlezz phanlezz enabled auto-merge (rebase) June 3, 2024 11:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@phanlezz phanlezz merged commit 3b8650a into main Jun 3, 2024
7 checks passed
@phanlezz phanlezz deleted the feature/3493/overhaul-suspicious-metrics-menu-a17 branch June 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereboss Nereboss Nereboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul the Suspicious Metrics menu
4 participants
@ViktoriaGordeevaVG @ChristianHuehn @Nereboss @phanlezz