Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1539/add zoom slider #3697

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Feature/1539/add zoom slider #3697

merged 9 commits into from
Aug 22, 2024

Conversation

IdrisLaabidi
Copy link
Contributor

@IdrisLaabidi IdrisLaabidi commented Aug 21, 2024 •
edited
Loading

Add a zoom slider component

Issue: #1539

Description

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

image

@IdrisLaabidi IdrisLaabidi linked an issue Aug 21, 2024 that may be closed by this pull request
Add visible zoom function #1539
Closed
@IdrisLaabidi IdrisLaabidi added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:low Set by PO feature Feature requests labels Aug 21, 2024
phanlezz
phanlezz approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IdrisLaabidi IdrisLaabidi merged commit 07fc9ed into main Aug 22, 2024
7 checks passed
@IdrisLaabidi IdrisLaabidi deleted the feature/1539/add-zoom-slider branch August 22, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanlezz phanlezz phanlezz approved these changes

Assignees
No one assigned
Labels
feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:low Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add visible zoom function
2 participants
@IdrisLaabidi @phanlezz