Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3685/mcc migration #3728

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Feature/3685/mcc migration #3728

merged 12 commits into from
Sep 11, 2024

Conversation

Nereboss
Copy link
Contributor

@Nereboss Nereboss commented Sep 9, 2024

Add mcc rename option to StructureModifier

Issue: #3685

Description

Adds an option to rename the outdated 'mcc' metric to either 'complexity' or 'sonar_complexity' to the StructureModifier.
This does not yet close the connected issue as it also includes more todo for the visualisation

Behaviour of the new flag:

  • Renames all instances of mcc as an attribute in the file
  • Metrics that only contain mcc as a portion of their name are unchanged
  • Throws an error when one of the values for mcc is empty or null
  • When no mcc metric was found, it still creates an output but gives an info message, that the result is unaltered

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@Nereboss Nereboss marked this pull request as ready for review September 10, 2024 09:38
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

analysis/filter/StructureModifier/README.md Outdated Show resolved Hide resolved
analysis/CHANGELOG.md Outdated Show resolved Hide resolved
@Nereboss Nereboss enabled auto-merge (rebase) September 11, 2024 09:21
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

sonarcloud bot commented Sep 11, 2024

@Nereboss Nereboss merged commit ffa5e30 into main Sep 11, 2024
7 checks passed
@Nereboss Nereboss deleted the feature/3685/mcc-migration branch September 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants