Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/3755/thousands sepeartion #3758

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

polina-schoenfeld-mw
Copy link
Collaborator

@polina-schoenfeld-mw polina-schoenfeld-mw commented Sep 18, 2024

Add Thousands Seperation for metrics

Closed: #3755

Description

  • add Thousands Seperation for metrics

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@polina-schoenfeld-mw polina-schoenfeld-mw enabled auto-merge (squash) September 18, 2024 12:08
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link

sonarcloud bot commented Sep 18, 2024

@polina-schoenfeld-mw polina-schoenfeld-mw merged commit 650c801 into main Sep 18, 2024
7 checks passed
@polina-schoenfeld-mw polina-schoenfeld-mw deleted the refactor/3755/thousands-sepeartion branch September 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add thousands separation for metrics
2 participants