-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/2498/remove example maps #3768
Conversation
Clearing webstorage was required. #3641. |
Currently clears sample1,sample2 when opening dev/standalone. Does not clear default maps when opening webdemo (the codecharta maps). |
Nah it should also delete them on the webdemo. In general we just want to get the following:
To make this easier we should probably just remove the maps from the url query parameters once |
7d97ca8
to
d155e72
Compare
Fixed the issue without addressing the removal of the URL parameter "file". I think this should be a new issue, since currently the URL parameter "file" is only related with the shown maps on initial loading of the site and not updated after. |
960cd94
to
ee27b2b
Compare
# Conflicts: # visualization/CHANGELOG.md
ee27b2b
to
74dec9f
Compare
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
remove example maps
Closes: #2498
Description
If there are sample files loaded as fallback maps when starting the application,
then those files are removed as soon as the user uploads own files.
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled:
Screenshots or gifs