Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2498/remove example maps #3768

Merged
merged 17 commits into from
Oct 21, 2024
Merged

Fix/2498/remove example maps #3768

merged 17 commits into from
Oct 21, 2024

Conversation

BenediktMehl
Copy link
Collaborator

remove example maps

Closes: #2498

Description

If there are sample files loaded as fallback maps when starting the application,
then those files are removed as soon as the user uploads own files.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@phanlezz
Copy link
Collaborator

phanlezz commented Sep 27, 2024

Clearing webstorage was required. #3641.

@phanlezz
Copy link
Collaborator

phanlezz commented Sep 27, 2024

Currently clears sample1,sample2 when opening dev/standalone. Does not clear default maps when opening webdemo (the codecharta maps).
I think that behavior is good, as the fallback gets cleared, and in the webdemo they are regular maps opened. What do you think @ChristianHuehn ?

@CodeCharta
Copy link
Contributor

Nah it should also delete them on the webdemo.

In general we just want to get the following:

  • Person opens web demo
  • Sees CodeCharta with Analaysis and Visualization
  • uploads his own maps
  • Visualization and analysis should be removed as they want to focus on the stuff that they uploaded

To make this easier we should probably just remove the maps from the url query parameters once

@BenediktMehl BenediktMehl force-pushed the fix/2498/remove-example-maps branch from 7d97ca8 to d155e72 Compare October 17, 2024 10:42
@BenediktMehl
Copy link
Collaborator Author

BenediktMehl commented Oct 17, 2024

To make this easier we should probably just remove the maps from the url query parameters once

Fixed the issue without addressing the removal of the URL parameter "file". I think this should be a new issue, since currently the URL parameter "file" is only related with the shown maps on initial loading of the site and not updated after.

@BenediktMehl BenediktMehl force-pushed the fix/2498/remove-example-maps branch from 960cd94 to ee27b2b Compare October 17, 2024 13:48
@phanlezz phanlezz force-pushed the fix/2498/remove-example-maps branch from ee27b2b to 74dec9f Compare October 21, 2024 09:00
@phanlezz phanlezz enabled auto-merge (rebase) October 21, 2024 09:01
Copy link

sonarcloud bot commented Oct 21, 2024

Copy link

sonarcloud bot commented Oct 21, 2024

@phanlezz phanlezz merged commit f713ec2 into main Oct 21, 2024
7 checks passed
@phanlezz phanlezz deleted the fix/2498/remove-example-maps branch October 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove example maps as soon as the user loads own cc.json files
3 participants