-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech/3716/enable view encapsulation in ribbon bar #3779
Merged
LisaWalter90
merged 22 commits into
main
from
tech/3716/enable-view-encapsulation-in-ribbon-bar
Oct 9, 2024
Merged
Tech/3716/enable view encapsulation in ribbon bar #3779
LisaWalter90
merged 22 commits into
main
from
tech/3716/enable-view-encapsulation-in-ribbon-bar
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eightMetricButtonComponent
LisaWalter90
approved these changes
Oct 9, 2024
Quality Gate passed for 'CodeCharta Visualization'Issues Measures |
Quality Gate passed for 'CodeCharta Analysis'Issues Measures |
LisaWalter90
deleted the
tech/3716/enable-view-encapsulation-in-ribbon-bar
branch
October 9, 2024 12:19
ViktoriaGordeevaVG
added a commit
that referenced
this pull request
Oct 10, 2024
* add restriction to how much the user can rotate the map #3730 * update Three.js to the latest version #3730 * Limit rotation of camera and refactor viewcube accordingly * Adjust wrong camera rotations and update tests #3730 * Fix failing font tests #3730 * Remove spaces to hopefully make linter happy #3730 * add tests for the viewCube meshGenerator #3735 * Feat/3771/comparison of incompatible maps (#3773) * feat(visualization): open incompatibleMapsDialog in filePanelDeltaSelector if necessary * feat(visualization): open incompatibleMapsDialog with the correct data and show file with the mcc metric * feat(visualization): add checkbox to disable alert * feat(visualization): add and improve styling * feat(visualization): add styling * test(visualization): delete e2e test * test(visualization): add tests * chore(visualization): formatting * chore(visualization): update changelog * refactor(visualization): add data mock and rename old one * test(visualization): add tests for FilePanelDeltaSelectorComponent --------- Co-authored-by: lisa.walter <lisa.walter@maibornwolff.de> * Feature/3745/structure incompatible file merge (#3774) * #3745 add a pre-check before merging (non-)overlapping already specified modules * #3745 expand the pre-check merge process for non-overlapping modules in the ParserDialog * #3745 add Unit Tests * #3745 add Changelog.md * #3745 fix kotlin style violations * #3745 fix kotlin style violations * #3745 add Test to warn about invalid project files * #3745 add Unit Tests * #3745 wip * #3745 fix the invalidInput exception * #3745 remove comments in MergeFilterTest --------- Co-authored-by: VictoriaG <victoria.gordeeva@maibornwolff.de> * Tech/3716/enable view encapsulation in ribbon bar (#3779) * feat(visualization): enable view encapsulation in show scenarios button * feat(visualization): enable view encapsulation in scenarios menu * feat(visualization): enable view encapsulation in thumbTackButton and sortingButton * feat(visualization): enable View Encapsulation for sortingOption * feat(visualization): enable View Encapsulation for MatchingFilesCounterComponent * fix(visualization): import styling * feat(visualization): enable View Encapsulation for SearchPanelModeSelectorComponent * feat(visualization): enable View Encapsulation for SearchBar * feat(visualization): enable View Encapsulation for blacklistPanel * feat(visualization): enable View Encapsulation for LinkColorMetricToHeightMetricButtonComponent * feat(visualization): enable view encapsulation in settings panels * feat(visualization): enable view encapsulation in suspicious metrics dialog * feat(visualization): enable View Encapsulation for range slider * feat(visualization): enable View Encapsulation for edgeMetricToggle * feat(visualization): enable View Encapsulation for highRiskProfile * feat(visualization): enable View Encapsulation for suspiciousMetrics * refactor(visualization): add css file for suspiciousMetricsList * feat(visualization): enable ViewEncapsulation for artificialIntelligence * chore(visualization): update changelog --------- Co-authored-by: lisa.walter <lisa.walter@maibornwolff.de> Co-authored-by: Lisa Walter <mailtolisawalter@gmail.com> * resolve merge conflict * update Three.js to the latest version #3730 * Limit rotation of camera and refactor viewcube accordingly * Adjust wrong camera rotations and update tests #3730 * Fix failing font tests #3730 * add tests for the viewCube meshGenerator #3735 --------- Co-authored-by: nereboss <niklas.kneissl@gmail.com> Co-authored-by: Niklas Kneißl <105795397+Nereboss@users.noreply.github.com> Co-authored-by: polina-schoenfeld-mw <polina.schoenfeld@maibornwolff.de> Co-authored-by: lisa.walter <lisa.walter@maibornwolff.de> Co-authored-by: ViktoriaGordeevaVG <148755651+ViktoriaGordeevaVG@users.noreply.github.com> Co-authored-by: VictoriaG <victoria.gordeeva@maibornwolff.de> Co-authored-by: Lisa Walter <mailtolisawalter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable View Encapsulation for RibbonBar Components
Closes: #3716
Description
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: