Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the zooming change on focus and restore old functionality #3793

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Revert the zooming change on focus and restore old functionality #3793

merged 8 commits into from
Oct 25, 2024

Conversation

IhsenBouallegue
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue commented Oct 21, 2024 •
edited
Loading

Revert the zooming change on focus and restore old functionality

Please read the CONTRIBUTING.md before opening a PR.

Closes: #3761

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@IhsenBouallegue IhsenBouallegue marked this pull request as ready for review October 23, 2024 07:22
polina-schoenfeld-mw
polina-schoenfeld-mw requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@polina-schoenfeld-mw polina-schoenfeld-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In den Kommentaren gibt es noch paar Kleinigkeiten, wie das Hinzufügen von Typen oder das Inlinen einer Stelle, die angepasst werden können.

@IhsenBouallegue IhsenBouallegue enabled auto-merge (squash) October 25, 2024 10:12
@IhsenBouallegue IhsenBouallegue enabled auto-merge (squash) October 25, 2024 10:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IhsenBouallegue IhsenBouallegue merged commit 0d29fce into main Oct 25, 2024
7 checks passed
@IhsenBouallegue IhsenBouallegue deleted the fix/3761/focux-should-not-zoom branch October 25, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-schoenfeld-mw polina-schoenfeld-mw polina-schoenfeld-mw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Focus does not zoom on a specific building
2 participants
@IhsenBouallegue @polina-schoenfeld-mw