Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(visualization): add missing root injectable configuration (#3840) #3842

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Dec 4, 2024

Fix Custom View Menu's missing Service

Closes: #3840

  • add the root injectable config to a few services, which were declared in root anyway

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Copy link

sonarcloud bot commented Dec 4, 2024

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Dec 4, 2024

@phanlezz phanlezz merged commit 0e3852a into main Dec 4, 2024
8 checks passed
@phanlezz phanlezz deleted the fix/3840/custom-view-not-working branch December 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom View is broken
2 participants