修复 GameMgr is not defined #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yesterday17
requested changes
Oct 7, 2019
src/extension/manager.ts
Outdated
| $.pre.map(ext => \`majsoul_plus/extension/scripts/\${ext}/\`).forEach(url => addScript(url)); | ||
| await Promise.all( | ||
| $.pre.map(ext => addScript(\`majsoul_plus/extension/scripts/\${ext}/\`)) | ||
| ); | ||
|
|
||
| if ($.hasLauncher) { | ||
| addScript(\`majsoul_plus/extension/scripts/\${$.launcher}/\`) |
fa93hws
commented
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83
刚clone没多久，对代码库没有任何了解，因此这个fix很可能不正确
问题似乎是因为
new GameMgr();的执行并不能保证在code.js的异步载入之后。await似乎是在f9c2ece#diff-3d6ed586bad3d1920a53b8c92c6f14de
中被移除的