Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Add Covid-19 Dungeon #110

Merged
merged 4 commits into from Dec 10, 2020
Merged

Add Covid-19 Dungeon #110

merged 4 commits into from Dec 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2020

Hello friends,

I added a new dungeon which has the Covid-19 theme. But, I am lost in it, confused and I don't know what to write next 😭 . Can someone complete this for me? I can help as well.

Created to Address #103, but couldn't finish

I don't have a skill of story writing, so I think I am unable to do this. But, I will work on other areas 😐.

Thanks for understanding.

@ming-tsai
Copy link
Member

Hi @paulsonjpaul, you could let it open, and jump into this file english/normal-dungeon/4/0.md

@ghost
Copy link
Author

ghost commented Dec 1, 2020

Alright. I didn't know about this. There are many files in this repo! I will check it out when I am free.

Can you please add some labels to this PR (help wanted, etc.), so that some newcomers will be driven here and do some contributions?

@ming-tsai ming-tsai added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 1, 2020
@ming-tsai ming-tsai assigned ghost Dec 1, 2020
@FukurouMakoto
Copy link
Contributor

Love the idea on this lol.
Would it be okay if I work on this issue if no new people have jumped on it after a couple of weeks maybe?
I like the idea of it but I really want to have some new people pick it up and run with it.

@ghost
Copy link
Author

ghost commented Dec 6, 2020

@FukurouMakoto, yes. You can take this if no one is interested in this after a couple of weeks.

@ghost
Copy link
Author

ghost commented Dec 6, 2020

I have an idea. How about I add a new issue and link it to this PR? That might bring some new people.

@ghost
Copy link
Author

ghost commented Dec 6, 2020

I have another question. How can a new person (non-member of this organization) work on this PR? Only members can edit this PR, right?

@ming-tsai
Copy link
Member

I have an idea. How about I add a new issue and link it to this PR? That might bring some new people.

Yes you could do it

@ming-tsai
Copy link
Member

I have another question. How can a new person (non-member of this organization) work on this PR? Only members can edit this PR, right?

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

@ghost
Copy link
Author

ghost commented Dec 7, 2020

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

Will that allow a non-member to edit this Pull Request? I am talking about this specific PR, not the whole repo.

@ming-tsai
Copy link
Member

ming-tsai commented Dec 8, 2020

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

Will that allow a non-member to edit this Pull Request? I am talking about this specific PR, not the whole repo.

Yes, the issue will be published on up-for-grabs

@ghost
Copy link
Author

ghost commented Dec 9, 2020

Ok. Can you please open the issue? I don't know what to write as steps.

@Arsenic-ATG
Copy link
Member

Arsenic-ATG commented Dec 9, 2020

Hello friends,

I added a new dungeon which has the Covid-19 theme. But, I am lost in it, confused and I don't know what to write next 😭 . Can someone complete this for me? I can help as well.

Created to Address #103, but couldn't finish

I don't have a skill of story writing, so I think I am unable to do this. But, I will work on other areas 😐.

Thanks for understanding.

@paulsonjpaul new dungeons are not meant to be complete, in fact the purpose of this repository to exist is to help new comers get familiar with the GitHub environment by doing small contributions
if you want, you can let the changes done so far be merged in the main repo so that other people can also expand the story on their own level and not have to change your pull request again and again.

Also if your pull request is still work in progress then it is much better to convert the pull request to a draft than adding a (WIP) tag in the title as then it will be safe from accidental merges 🙂.

@ghost
Copy link
Author

ghost commented Dec 10, 2020

Thanks @Arsenic-ATG . I had planned about making the PR a draft, but was not sure what it would do.

if you want, you can let the changes done so far be merged in the main repo so that other people can also expand the story on their own level and not have to change your pull request again and again.

Ok. That seems a good idea. After merging, I will open an issue so that new users will be able to complete it.

@ming-tsai and other members, can you review this and merge?

Paulson J Paul added 2 commits December 10, 2020 08:58
As this covid-19 dungeon is work in progress, there are many options which are not linked to any files. So, I have added a `WIP.md` file and linked all unlinked files to this new file.

If you are interested in completing this dungeon, please see [Contribution Guidelines](../../../README.md#contribution-guidelines)
Arsenic-ATG
Arsenic-ATG previously approved these changes Dec 10, 2020
Copy link
Member

@Arsenic-ATG Arsenic-ATG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good 👍 but there are files (have got comment in them) which doesn't have any progressive link.

I am still approving✅ them as they are not that big of a problems and as this dungeon is work in progress, can easily be fixed by someone anytime in future.

I leave the final decision to merge on @ming-tsai

english/covid-19/0/0-CA.md Show resolved Hide resolved
english/covid-19/2/2-A.md Show resolved Hide resolved
english/covid-19/2/2.md Show resolved Hide resolved
english/covid-19/3/3.md Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Dec 10, 2020

@Arsenic-ATG please see my reply to your comments

Removed add some options here placeholder.
@sonarcloud
Copy link

sonarcloud bot commented Dec 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ming-tsai ming-tsai merged commit 2df58b0 into MakeContributions:master Dec 10, 2020
@ming-tsai
Copy link
Member

Nice work @paulsonjpaul and @Arsenic-ATG

@ming-tsai ming-tsai changed the title Add Covid-19 Dungeon (WIP) Add Covid-19 Dungeon Dec 10, 2020
@ming-tsai ming-tsai linked an issue Dec 10, 2020 that may be closed by this pull request
@ming-tsai ming-tsai linked an issue Dec 10, 2020 that may be closed by this pull request
@ghost ghost deleted the add-dungeon-covid-19 branch December 11, 2020 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvise COVID-19 dungeon Add more dungeons, rooms or floors - Part 3
3 participants