-
Notifications
You must be signed in to change notification settings - Fork 149
Conversation
Hi @paulsonjpaul, you could let it open, and jump into this file english/normal-dungeon/4/0.md |
Alright. I didn't know about this. There are many files in this repo! I will check it out when I am free. Can you please add some labels to this PR (help wanted, etc.), so that some newcomers will be driven here and do some contributions? |
Love the idea on this lol. |
@FukurouMakoto, yes. You can take this if no one is interested in this after a couple of weeks. |
I have an idea. How about I add a new issue and link it to this PR? That might bring some new people. |
I have another question. How can a new person (non-member of this organization) work on this PR? Only members can edit this PR, right? |
Yes you could do it |
You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it |
Will that allow a non-member to edit this Pull Request? I am talking about this specific PR, not the whole repo. |
Yes, the issue will be published on up-for-grabs |
Ok. Can you please open the issue? I don't know what to write as steps. |
@paulsonjpaul new dungeons are not meant to be complete, in fact the purpose of this repository to exist is to help new comers get familiar with the GitHub environment by doing small contributions Also if your pull request is still work in progress then it is much better to convert the pull request to a draft than adding a (WIP) tag in the title as then it will be safe from accidental merges 🙂. |
Thanks @Arsenic-ATG . I had planned about making the PR a draft, but was not sure what it would do.
Ok. That seems a good idea. After merging, I will open an issue so that new users will be able to complete it. @ming-tsai and other members, can you review this and merge? |
As this covid-19 dungeon is work in progress, there are many options which are not linked to any files. So, I have added a `WIP.md` file and linked all unlinked files to this new file. If you are interested in completing this dungeon, please see [Contribution Guidelines](../../../README.md#contribution-guidelines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good 👍 but there are files (have got comment in them) which doesn't have any progressive link.
I am still approving✅ them as they are not that big of a problems and as this dungeon is work in progress, can easily be fixed by someone anytime in future.
I leave the final decision to merge on @ming-tsai
@Arsenic-ATG please see my reply to your comments |
Removed add some options here placeholder.
Kudos, SonarCloud Quality Gate passed! |
Nice work @paulsonjpaul and @Arsenic-ATG |
Hello friends,
I added a new dungeon which has the Covid-19 theme. But, I am lost in it, confused and I don't know what to write next 😭 . Can someone complete this for me? I can help as well.
Created to Address #103, but couldn't finish
I don't have a skill of story writing, so I think I am unable to do this. But, I will work on other areas 😐.
Thanks for understanding.