Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing submodule build and export #145

Merged
merged 2 commits into from
May 30, 2024

Conversation

cuzzlor
Copy link
Collaborator

@cuzzlor cuzzlor commented May 30, 2024

A couple of issues with v1.4.0: the addition of the /testing submodule:

  1. ./src/testing/index.ts was missing from the rollup config so the code was not included (only the type defs)
  2. ./testing was missing from the package.json exports section

Fixing the exports results in this generated package.json content:

  "main": "./index.js",
  "module": "./index.mjs",
  "types": "./index.d.ts",
  "type": "commonjs",
  "exports": {
    ".": {
      "types": "./index.d.ts",
      "import": "./index.mjs",
      "require": "./index.js"
    },
    "./testing": {
      "types": "./testing/index.d.ts",
      "import": "./testing/index.mjs",
      "require": "./testing/index.js"
    }
  }

@cuzzlor cuzzlor requested a review from robdmoore May 30, 2024 07:13
@cuzzlor cuzzlor marked this pull request as draft May 30, 2024 07:26
@cuzzlor cuzzlor removed the request for review from robdmoore May 30, 2024 07:27
@cuzzlor cuzzlor force-pushed the fix-testing-submodule-build-and-export branch from 5d7f914 to 530f853 Compare May 30, 2024 07:32
@cuzzlor cuzzlor marked this pull request as ready for review May 30, 2024 07:32
@mderriey
Copy link
Member

Fixing the exports results in this generated package.json content

👌

@cuzzlor cuzzlor requested a review from robdmoore May 30, 2024 07:37
@cuzzlor cuzzlor merged commit 3ed63f6 into main May 30, 2024
2 checks passed
@cuzzlor cuzzlor deleted the fix-testing-submodule-build-and-export branch May 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants