v1.3 #6
v1.3 #6
Conversation
|
|
||
| namespace WikiPreview.Fluent.Plugin | ||
| { | ||
| public class CustomPreview : IResultPreviewControlBuilder |
There was a problem hiding this comment.
Better to follow the interface name WikiResultPreviewControlBuilder
|
|
||
| public bool CanBuildPreviewForResult(ISearchResult searchResult) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(searchResult.SearchApp)) return false; |
There was a problem hiding this comment.
This condition is redundant since you do Equals below, if it was empty the Equals will return false
| private ResultGenerator() | ||
| { | ||
| var assembly = Assembly.GetExecutingAssembly(); | ||
| const string resourceName = "WikiPreview.Fluent.Plugin.Wikipedia-logo.png"; |
There was a problem hiding this comment.
No need to declare const if you only use it below
There was a problem hiding this comment.
For some reasons, IDE would keep on suggesting me to declare const. I'm directly giving the string literal now, let me know on this.
|
|
||
| private readonly BitmapImageResult _bitmapLogo; | ||
|
|
||
| private ResultGenerator() |
There was a problem hiding this comment.
Why do you need to load the image every time this class is created? Make it a static property
There was a problem hiding this comment.
It was a Singleton before where only same instance will be provided. Now I've made it into static class as per your suggestions.
| { | ||
| public sealed class ResultGenerator | ||
| { | ||
| private static readonly Lazy<ResultGenerator> LazySingleton = |
There was a problem hiding this comment.
Are you using lazy to not create the instance of the image below? Are there any cases you search with Wiki and not load it?
There was a problem hiding this comment.
Yes, it was mainly for loading the instance of the image and also store the image size preferences, also making it accessible across all classes. Earlier I thought lazy implementation can be more efficient. In the new code, I've achieved the same behavior that I wanted in a static way.
| using var imageClient = new HttpClient(); | ||
| imageClient.DefaultRequestHeaders.UserAgent.TryParseAdd(UserAgentString); | ||
| Stream stream = await imageClient.GetStreamAsync(imgUrl); | ||
| var bitmap = new Bitmap(stream); |
There was a problem hiding this comment.
Are you creating Bitmap since the Avalonia one does not support it?
There was a problem hiding this comment.
Yeah, AvaloniaBitmap is not working for some unknown reasons. In fact, it's breaking the plugin completely.
| var wiki = await httpClient.GetFromJsonAsync<Wiki>(url, SerializerOptions); | ||
| if (wiki == null) return default; | ||
|
|
||
| Dictionary<string, PageView>.ValueCollection pages = wiki.Query.Pages.Values; |
There was a problem hiding this comment.
Check for null wiki?.Query?.Pages?.Values
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="AsyncEnumerator" Version="4.0.2"/> | ||
| <PackageReference Include="Blast.API" Version="0.9.89.1-beta"/> |
| <ItemGroup> | ||
| <PackageReference Include="AsyncEnumerator" Version="4.0.2"/> | ||
| <PackageReference Include="Blast.API" Version="0.9.89.1-beta"/> | ||
| <PackageReference Include="TextCopy" Version="1.5.1"/> |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="Wikipedia-logo.png"/> |
| using var imageClient = new HttpClient(); | ||
| imageClient.DefaultRequestHeaders.UserAgent.TryParseAdd(UserAgentString); | ||
|
|
||
| using HttpResponseMessage response = |
There was a problem hiding this comment.
You can use GetAsStream instead of using GetAsync and then ReadAsStreamAsync
SearchTagOnlyoption.