Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "GeoInterface" to "1.0" #115

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the GeoInterface package from 0.5 to 0.5, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@asinghvi17 asinghvi17 closed this May 17, 2022
@asinghvi17 asinghvi17 reopened this May 17, 2022
@asinghvi17 asinghvi17 merged commit ea3e71b into master May 18, 2022
@asinghvi17 asinghvi17 deleted the compathelper/new_version/2022-05-17-18-20-49-511-4290090143 branch May 18, 2022 01:16
@rafaqz
Copy link

rafaqz commented Jun 15, 2022

FYI GeoInterface 1.0 has completely new internals, and relying on coordinates to standardise geometries is no longer the best strategy - the eager allocation of nested vectors is pretty inefficient.

Instead you can access all compatible objects laziliy, e.g. using getgeom. You can also use GeoInterface.x GeoInterface.y etc to access the values of any point object.

When we have Feature handling completely finalised it would also be good to have an easy way to plot feature properties.

@visr
Copy link
Collaborator

visr commented Jun 15, 2022

Yeah I think we can work on the GeoInterface integration when JuliaGeometry/GeometryBasics.jl#175 and JuliaGeo/GeoJSON.jl#36 are ready, since this package relies on both packages. Right now GeoInterface 1 cannot be used with this package because GeoJSON.jl is preventing that.

These conversions won't be needed anymore:

https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/conversions.jl#L4-L53

And these assets can be updated:

https://github.com/JuliaPlots/GeoMakie.jl/blob/ea3e71baa108a90f924172bf59de3519380bd769/src/data.jl#L11-L24

@visr visr mentioned this pull request Jun 15, 2022
@rafaqz
Copy link

rafaqz commented Jun 15, 2022

Yeah ok thats on me. Currently getting Rasters.jl updated and all the upstream PRs for that to work. But I'll be back to GeoJSONTables.jl soon.

Mostly the block was getting write finished so we don't lose that functionality.

@visr
Copy link
Collaborator

visr commented Jun 15, 2022

Yeah no rush, luckily we have [compat] and can roll this out gradually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants