Icons #223
Merged
Icons #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonDanisch this is ready for review |
|
GLFW has been tagged. |
|
Very cool! Works on windows + linux... Did you, by any chance, run this on osx? |
|
the GLFW icon function does not do anything on osx, it's only for Windows and Linux Thanks for the review |
|
BTW there are other options at https://www.flaticon.com/packs/charts-and-diagrams-14 we could use I kinda arbitrarily chose which one I thought looked decent. A future goal could be to expose the icon interface, so users can use their own icons for custom applications. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #197
(sorry but I wanted to commit my changes to a new branch)