Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use linestyle in triplot #4332

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

DanielVandH
Copy link
Contributor

@DanielVandH DanielVandH commented Sep 6, 2024

Description

Noticed that triplot wasn't using the linestyle argument

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@ffreyer
Copy link
Collaborator

ffreyer commented Sep 18, 2024

I tweaked another refimg instead of adding a new one to save a bit of CI time.

I also noticed that some lines are overlapping. I guess that's expected though?

@DanielVandH
Copy link
Contributor Author

DanielVandH commented Sep 18, 2024

I also noticed that some lines are overlapping. I guess that's expected though?

Is there a way to view the new images from the CI without going into the code itself? I can double check.

Oh it's just from the uploaded artifacts.
image

Is there overlap? I can't see it.

@ffreyer
Copy link
Collaborator

ffreyer commented Sep 18, 2024

It's easier to see when you make the plot locally an rescale the window. I think all the central lines are duplicated. In this example the one to the top left appears solid, along with some others:

image

In your example the one straight down in the center and two diagonal ones connected to either endpoint of that line show it.

@ffreyer
Copy link
Collaborator

ffreyer commented Sep 18, 2024

Actually maybe that's just poly?

@ffreyer
Copy link
Collaborator

ffreyer commented Sep 18, 2024

Yea nvm, that's just #2694. I'll merge this once ci passes

@ffreyer ffreyer merged commit bd6eb7e into MakieOrg:master Sep 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants