Use Base.depwarn() exclusively, and fix deprecation tests
#4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes: - Use `Base.depwarn()` instead of `Base.@deprecate_binding` to avoid warnings when importing symbols. - Pass the missing `funcsym` argument to `Base.depwarn()` in `Combined()`. - Fix the deprecation tests. Most of them were actually getting skipped because `@depwarn_message` had a `return` statement, causing the entire testset to return early as soon as the passed expression was evaluated.
src/deprecated.jl
Outdated
| Base.@deprecate_binding ContinuousSurface VertexGrid true | ||
|
|
||
| function DiscreteSurface(args...; kwargs...) | ||
| Base.depwarn("Makie.DiscreteSurface() is deprecated, use Makie.CellGrid() instead", :DiscreteSurface) |
There was a problem hiding this comment.
Should we actually make this a warning with maxlog=1?
Every time we remove deprecations in a breaking version, people are confused why suddenly things are broken without a warning, since depwarns are turned off almost everywhere it matters for a plotting package.
There was a problem hiding this comment.
Ok, changed to @warn in 5c3829c.
|
Thanks :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes #4308.
A few changes:
Base.depwarn()instead ofBase.@deprecate_bindingto avoid warnings when importing symbols.funcsymargument toBase.depwarn()inCombined().@depwarn_messagehad areturnstatement, causing the entire testset to return early as soon as the passed expression was evaluated.Type of change
Checklist
(I don't think this needs a changelog entry?)