Don't allow key + string #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some operators have a fixed return type. In these cases, to prevent a cascade of invalid operation errors, assign the return type of the operator, rather than that of the first operand. That type happens to be integer in all cases handled. This is especially important in the case of >= and <= because that's parsed as !(a < b) and !(a > b) respectively, and if there's a type mismatch in the inner operation, another error is raised in the ! operation, potentially confusing the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from a copy-paste too much, there was an entry in the table of valid operator types for key + string -> key. That's been removed, and a new test case has been added that covers every possible operator combination, to ensure there are no more problems of that kind.
There's a known bug in the handled operand types: integer *= float should be supported (see #16).